Ticket #2053 (closed defect: fixed)

Opened 15 years ago

Last modified 15 years ago

Memory leak in mc_symlink() function

Reported by: vit_r Owned by: andrew_b
Priority: major Milestone: 4.7.1
Component: mc-vfs Version: master
Keywords: Cc:
Blocked By: Blocking:
Branch state: Votes for changeset: committed-master committed-stable

Description (last modified by andrew_b) (diff)

when a try to bring this old fashion style 

    mpath = ...
    if (mpath != NULL) {
    vfs = vfs_get_class (mpath);
    result = vfs->setctl ? (...) : 0;
    g_free (mpath);
    return result;
    } else return -1;

to currently (for mc) looking like

    mpath = ...
    if (mpath == NULL)
	return -1;
	
    vfs = vfs_get_class (mpath);
    result = vfs->setctl ? (...) : 0;
    g_free (mpath);
    return result;

this missing g_free() popped up



Attachments

2053-lib-vfs-mc-vfs-vfs.c-mc_symlink-missing-g_free.patch​ (798 bytes) - added by vit_r 15 years ago.

Change History

Changed 15 years ago by vit_r

comment:1 Changed 15 years ago by andrew_b

  • Status changed from new to accepted
  • Description modified (diff)
  • Priority changed from trivial to major
  • Milestone changed from 4.7 to 4.7.1
  • Owner set to andrew_b
  • severity changed from no branch to on review

Created 2053_vfs_memleak branch. Parent branch is master.
changeset:37aee9a69aaf19bce9296f5cbe8e3dc93d815a9f

comment:2 Changed 15 years ago by slavazanko

  • Votes for changeset set to slavazanko

comment:3 Changed 15 years ago by andrew_b

  • Summary changed from lib-vfs-mc-vfs-vfs.c-mc_symlink-missing-g_free to Memory leak in mc_symlink() function

comment:4 Changed 15 years ago by angel_il

  • Votes for changeset changed from slavazanko to slavazanko angel_il
  • severity changed from on review to approved

comment:5 Changed 15 years ago by andrew_b

  • Status changed from accepted to testing
  • Votes for changeset changed from slavazanko angel_il to commited-master commited-stable
  • Resolution set to fixed
  • severity changed from approved to merged

Merged to master.
changeset:377004740772ef92d7e3f25803a9236830518676

Cherry-picked to 4.7.0-stable.
changeset:03a4c35e48a000f7c41f1be6f8aa54aa0e1d842a

comment:6 Changed 15 years ago by andrew_b

  • Status changed from testing to closed
Note: See TracTickets for help on using tickets.