Ticket #2050 (closed defect: fixed)

Opened 15 years ago

Last modified 15 years ago

[PATCH] Disable RAR/UNRAR user/system configuration for archive list and copyout operations in extfs/urar

Reported by: birdie Owned by: andrew_b
Priority: major Milestone: 4.7.2
Component: mc-vfs Version: master
Keywords: Cc:
Blocked By: Blocking:
Branch state: Votes for changeset: committed-master committed-stable

Description

My system wide .rarrc contains these switches

cat /usr/local/etc/.rarrc
switches= -m5 -mdG -r -s -t -ol -tl

So whenever you list the contents of any archive or copy a file out of it, RAR/UNRAR will traverse *all* sub directories (note -r, recursive switch) in a current directory trying to find *all* archives with the same name. So, the net result might be that unrar/rar will extract the wrong file and spend a lot of time trying to find archives with the same name.

That's why I strongly suggest disabling user/system configuration for archive list and copyout operations (note the added -cfg switch).

I have contacted Eugene Roshal and he said that he won't disable -r switch for extract and archive list operations, so, we can only fix this problem on our side.

Attachments

urar.disable.rar.configuration.for.list.and.copyout.patch​ (504 bytes) - added by birdie 15 years ago.

Change History

Changed 15 years ago by birdie

comment:1 Changed 15 years ago by andrew_b

  • Status changed from new to accepted
  • Votes for changeset set to andrew_b
  • severity changed from no branch to on review
  • Component changed from mc-core to mc-vfs
  • Version changed from version not selected to master
  • Milestone changed from 4.7 to 4.7.2
  • Owner set to andrew_b

Created 2050_urar_disable_user_cfg branch. Parent branch is master.
changeset:07de6670ed3c8ee4c2a223272727f152a1a716ab

comment:2 Changed 15 years ago by zaytsev

  • Votes for changeset changed from andrew_b to andrew_b zaytsev

comment:3 Changed 15 years ago by zaytsev

  • Keywords stable-candidate added

comment:4 Changed 15 years ago by zaytsev

  • Votes for changeset andrew_b zaytsev deleted
  • severity changed from on review to approved

comment:5 Changed 15 years ago by andrew_b

  • Keywords stable-candidate removed
  • Status changed from accepted to testing
  • Votes for changeset set to commited-master commited-stable
  • Resolution set to fixed
  • severity changed from approved to merged

Merged to master.
changeset:07de6670ed3c8ee4c2a223272727f152a1a716ab

Cherry-picked to 4.7.0-stable.
changeset:a6b5d6110306465aee998de778a632bcf870fef1

comment:6 Changed 15 years ago by andrew_b

  • Status changed from testing to closed
Note: See TracTickets for help on using tickets.