Ticket #2049 (closed defect: fixed)
[PATCH] extfs/urar doesn't correctly shows localized filenames in RAR archives
| Reported by: | birdie | Owned by: | andrew_b |
|---|---|---|---|
| Priority: | major | Milestone: | 4.7.2 |
| Component: | mc-vfs | Version: | master |
| Keywords: | Cc: | ||
| Blocked By: | Blocking: | ||
| Branch state: | Votes for changeset: | committed-master committed-stable |
Description
There's absolutely no need to export LC_ALL.
Attachments
Change History
Changed 15 years ago by birdie
- Attachment urar.localized.filenames.fix.patch added
comment:1 Changed 15 years ago by andrew_b
- Version changed from version not selected to master
- Component changed from mc-core to mc-vfs
comment:2 Changed 15 years ago by andrew_b
I've meant that there was some reason to use C locale in unrar script.
comment:3 Changed 15 years ago by birdie
I have exported LANG=ru_RU.KOI8-R and urar still works correctly:
[birdie@localhost tmp]$ locale
LANG=ru_RU.KOI8-R
LC_CTYPE="ru_RU.KOI8-R"
LC_NUMERIC="ru_RU.KOI8-R"
LC_TIME="ru_RU.KOI8-R"
LC_COLLATE="ru_RU.KOI8-R"
LC_MONETARY="ru_RU.KOI8-R"
LC_MESSAGES="ru_RU.KOI8-R"
LC_PAPER="ru_RU.KOI8-R"
LC_NAME="ru_RU.KOI8-R"
LC_ADDRESS="ru_RU.KOI8-R"
LC_TELEPHONE="ru_RU.KOI8-R"
LC_MEASUREMENT="ru_RU.KOI8-R"
LC_IDENTIFICATION="ru_RU.KOI8-R"
LC_ALL=
[birdie@localhost tmp]$ unrar v -c- 1.rar
UNRAR 3.91 freeware Copyright (c) 1993-2009 Alexander Roshal
Archive 1.rar
Size Packed Ratio Date Time Attr CRC Meth Ver
Тестовое имя файла
0 0 0% 21-02-10 15:57 .....A. 00000000 m0b 2.9
1 0 0 0%
_
Copying out still works.
Without this patch I file names in archive are garbled.
comment:4 Changed 15 years ago by andrew_b
- Status changed from new to accepted
- Owner set to andrew_b
- Votes for changeset set to andrew_b
- severity changed from no branch to on review
- Milestone changed from 4.7 to 4.7.2
Created 2049_urar_localized_filenames branch. Parent branch is master.
changeset:8bdd7bc7641e399f92eabfc74be3a99d1415ab4f
comment:5 Changed 15 years ago by angel_il
- Votes for changeset changed from andrew_b to andrew_b angel_il
- severity changed from on review to approved
comment:6 Changed 15 years ago by andrew_b
- Status changed from accepted to testing
- Votes for changeset changed from andrew_b angel_il to commited-master commited-stable
- Resolution set to fixed
- severity changed from approved to merged
Merged to master.
changeset:8bdd7bc7641e399f92eabfc74be3a99d1415ab4f
Cherry-picked to 4.7.0-stable.
31eef6b4712e98c90ff3e3c8f343aab9f34f66eb
Don't export LC_ALL in urar