Ticket #2041 (closed defect: fixed)

Opened 9 years ago

Last modified 9 years ago

missing retcheck of g_strdup_printf in logging.c

Reported by: vit_r Owned by: andrew_b
Priority: trivial Milestone: 4.7.2
Component: mc-core Version: master
Keywords: Cc:
Blocked By: Blocking:
Branch state: Votes for changeset: committed-master

Description

in lib/logging.c

              logfilename = g_strdup_printf (...)

retval ought to be checked.

two files are similar

first file shows what is it about


*FULL.patch is exactly the same except spaces

only one of them is to be applied


Attachments

2041-missing-g_strdup_printf-retcheck-in-logging.c.patch (814 bytes) - added by vit_r 9 years ago.
missing retcheck of g_strdup_printf in lib logging.c
2041-missing-g_strdup_printf-retcheck-in-logging.c-FULL.patch (2.2 KB) - added by vit_r 9 years ago.
missing retcheck of g_strdup_printf in lib logging.c

Change History

Changed 9 years ago by vit_r

missing retcheck of g_strdup_printf in lib logging.c

Changed 9 years ago by vit_r

missing retcheck of g_strdup_printf in lib logging.c

comment:1 Changed 9 years ago by andrew_b

  • Blocked By 2097 added
  • Milestone changed from 4.7 to 4.7.2

Applied with some modifications in 2097.

comment:2 Changed 9 years ago by andrew_b

  • Status changed from new to accepted
  • Owner set to andrew_b

comment:3 Changed 9 years ago by andrew_b

  • Blocked By 2097 removed

(In #2097) Merged to master.
changeset:f4e369c222543f864adfde7be211e9881cdf30a2

git log --pretty=oneline 4cea5be^...f4e369c

comment:4 Changed 9 years ago by andrew_b

  • Status changed from accepted to testing
  • Resolution set to fixed

comment:5 Changed 9 years ago by andrew_b

  • Status changed from testing to closed

comment:6 Changed 9 years ago by andrew_b

  • Votes for changeset set to committed-master
  • severity changed from no branch to merged
Note: See TracTickets for help on using tickets.