Ticket #2014 (closed defect: fixed)

Opened 14 years ago

Last modified 14 years ago

[PATCH] Don't try to make directory NULL named in mkdir_cmd()

Reported by: cosoleto Owned by: andrew_b
Priority: minor Milestone: 4.7.2
Component: mc-core Version: master
Keywords: Cc:
Blocked By: Blocking:
Branch state: Votes for changeset: committed-master committed-stable

Description (last modified by andrew_b) (diff)

As input_expand_dialog() may return a pointer to an empty string,
the function was trying to create a directory so named and thus
print a false "File exists" error message.
This is a regression due to commit 350c958f5efe2505aec590d5a964cafa4aab1c24 dated 4 Feb 2006, previously fixed in commit 382930fbf6e1d0ad40cc1b0f5d93db5c757531ca dated 16 Dec 2002.
Attached patch fix the problem.

Attachments

0001-Don-t-try-to-make-directory-NULL-named-in-mkdir_cmd.patch​ (904 bytes) - added by cosoleto 14 years ago.
0002-Fix-indentation-after-last-commit.patch​ (1.4 KB) - added by cosoleto 14 years ago.

Change History

Changed 14 years ago by cosoleto

Changed 14 years ago by cosoleto

comment:1 Changed 14 years ago by cosoleto

  • Summary changed from Don't try to make directory NULL named in mkdir_cmd() to [PATCH] Don't try to make directory NULL named in mkdir_cmd()

comment:2 Changed 14 years ago by andrew_b

  • Version changed from version not selected to master
  • Description modified (diff)

comment:3 Changed 14 years ago by andrew_b

  • Status changed from new to accepted
  • Owner set to andrew_b
  • Votes for changeset set to andrew_b
  • severity changed from no branch to on review
  • Milestone changed from 4.7 to 4.7.2

Created 2014_null_directory branch. Parent branch is master.
changeset:b4e13ce52e36beaff0f55b8db7943159c8c112a1

comment:4 Changed 14 years ago by slavazanko

  • Votes for changeset changed from andrew_b to andrew_b slavazanko
  • severity changed from on review to approved

comment:5 Changed 14 years ago by andrew_b

  • Status changed from accepted to testing
  • Votes for changeset changed from andrew_b slavazanko to commited-master
  • Resolution set to fixed
  • severity changed from approved to merged

Merged to master.
changeset:36771dcfa22b4954cba097946f66db0afdcf347e

comment:6 Changed 14 years ago by andrew_b

  • Status changed from testing to closed
  • Votes for changeset changed from commited-master to commited-master commited-stable

Cherry-picked to 4.7.0-stable.
changeset:c8ade19007457696a169dcb3145eb983c0c31fb0

Note: See TracTickets for help on using tickets.