Ticket #1977 (new defect) — at Initial Version

Opened 14 years ago

Last modified 12 years ago

unifying some declarations in edit dir

Reported by: vit_r Owned by:
Priority: trivial Milestone: 4.8.5
Component: mcedit Version: master
Keywords: Cc:
Blocked By: Blocking:
Branch state: merged Votes for changeset:

Description

Example

replacing

    int line
    int start_line

by

    long line
    long start_line



Note

'long' because of edit/edit-widget.h:
long total_lines; /* total lines in the file */, etc

would be better 'off_t', meanwhile majority is still 'long'.


So,

If dev-team will decide to re-declare lines
it will be easier when they are unified, isn't so ?

The other point (its my opinion):

There are similar 'int line, int col' for widgets
Would be better to call them somehow different
May be 'int wline, int wcol', at least


Change History

Changed 14 years ago by vit_r

some trivial corrections in edit dir

Note: See TracTickets for help on using tickets.