Ticket #1977 (closed defect: fixed)

Opened 9 years ago

Last modified 7 years ago

unifying some declarations in edit dir

Reported by: vit_r Owned by: andrew_b
Priority: trivial Milestone: 4.8.5
Component: mcedit Version: master
Keywords: Cc:
Blocked By: Blocking:
Branch state: merged Votes for changeset: committed-master committed-stable

Description (last modified by angel_il) (diff)

Example

replacing

    int line
    int start_line

by

    long line
    long start_line



Note

'long' because of edit/edit-widget.h:
long total_lines; /* total lines in the file */, etc

would be better 'off_t', meanwhile majority is still 'long'.


So,

If dev-team will decide to re-declare lines
it will be easier when they are unified, isn't so ?

The other point (its my opinion):

There are similar 'int line, int col' for widgets
Would be better to call them somehow different
May be 'int wline, int wcol', at least


Attachments

1977-unifying-some-declarations-in-edit-dir.patch (13.5 KB) - added by vit_r 9 years ago.
some trivial corrections in edit dir

Change History

Changed 9 years ago by vit_r

some trivial corrections in edit dir

comment:1 follow-up: ↓ 2 Changed 9 years ago by angel_il

  • Description modified (diff)
mc -V
GNU Midnight Commander, версия 4.7.0-pre4-227-gbd67eb8

Data types: char 8 int 32 long 32 void * 32 off_t 64 ecs_char 8

maybe you mean what we need replace int to off_t?

comment:2 in reply to: ↑ 1 Changed 9 years ago by vit_r

Replying to angel_il:

maybe you mean what we need replace int to off_t?

'int line, int col' for widgets are good as 'int' because of screen

but bad as 'line' and 'col' because 'line' and 'col' are already used for files.
Would they differ would be better, i think

'int wline, int wcol' - for widgets
'long line, long col' - for files at the moment

And latter they can become in all mc-code

'int wline, int wcol' - for widgets
'off_t line, off_t col' - for files

Meanwhile we can find 'int line' for both
For big files 'int line' will pop up, isn't so ?

comment:3 Changed 7 years ago by andrew_b

  • Branch state set to no branch
  • Milestone changed from 4.7 to Future Releases

comment:4 Changed 7 years ago by andrew_b

  • Owner set to andrew_b
  • Status changed from new to accepted
  • Branch state changed from no branch to on review
  • Milestone changed from Future Releases to 4.8.5

Branch: 1977_mcedit_type_accuracy (parent: master).
Initial changeset:fd5de62429a36a234b4cf3cc67672c97f28ae45f

comment:5 Changed 7 years ago by slavazanko

  • Votes for changeset set to slavazanko

comment:6 Changed 7 years ago by angel_il

  • Votes for changeset changed from slavazanko to slavazanko angel_il
  • Branch state changed from on review to approved

comment:7 Changed 7 years ago by andrew_b

Merged to master: [bf8755f4128955a6b3203d961036dc7f09eec38a].

git log --pretty=oneline b3258da..bf8755f

comment:8 Changed 7 years ago by andrew_b

  • Keywords stable-candidate added
  • Votes for changeset changed from slavazanko angel_il to committed-master
  • Branch state changed from approved to merged

comment:9 Changed 7 years ago by andrew_b

  • Status changed from accepted to testing
  • Resolution set to fixed

comment:10 Changed 7 years ago by andrew_b

  • Keywords stable-candidate removed
  • Status changed from testing to closed
  • Votes for changeset changed from committed-master to committed-master committed-stable

Merged to 4.8.1-stable: [5a64ae16d825cce19d4377232760a8fa65d4fbb0].

git log --pretty=oneline 0a42d17..5a64ae1
Note: See TracTickets for help on using tickets.