Ticket #1956 (closed defect: fixed)

Opened 9 years ago

Last modified 9 years ago

mcedit: moving cursor to the empty last line problem

Reported by: Graham Owned by: angel_il
Priority: minor Milestone: 4.7.1
Component: mcedit Version: master
Keywords: Cc:
Blocked By: Blocking:
Branch state: Votes for changeset: committed-master committed-stable

Description

Firstly, sorry for the long-winded nature of this report. This might be a trivial issue, but thought I'd bring it up.

In previous versions of mcedit, I could use the down arrow button to get to the last empty line when on the previous to last line, but it seems that in version 4.7.0.1 I can't do that. I can get to the last empty line from the previous last line if I use the right arrow button, but just can't seem to do so using the down arrow button. If there is text on the last line, then everything works as expected (or at least how I expected it to), just not if there's an empty last line. Part of me feels this might be intended behaviour, but it wasn't like this before and I personally prefer the old way (4.6.* and previous).

Steps to reproduce:

1 - Open mcedit and type in some lines of text, hitting return at the end of lines (wrap mode is off).

2 - On last line, hit the return, making a new empty line. Cursor should be on the new empty line.

3 - Go up to the above line with the up arrow key. Cursor should now be at the beginning of the previous line.

4 - Hit the down arrow key. The cursor will now be at the end of the current line, not at the beginning of the empty last line below.

5 - Hit the down arrow key again. The cursor will stay where it is, not going to the next line.

6 - Hit the right arrow key. The cursor will move to the empty last line.

What I should expect is that the cursor should go to the next line when I hit the down arrow key, whether it's an empty last line or not.

BTW, if I set editor_cursor_beyond_eol=1, then the behaviour I wish for does return. However, I don't operate my text editor in this mode, preferring that my cursor moves to the next line when it goes past the end of the line.

I compiled 4.7.0.1 on Debian Lenny with "./configure --with-glib2 --without-ext2undel --enable-charset --without-samba --with-screen=slang". The behaviour happens on the console and on an xterm (Xfce's Terminal).

If this is desired behaviour, then sorry for the bug report and noise (I did do a search, but maybe I missed it). However, if it is desired behaviour by the devs, can there be an option to return to the previous behaviour?

Thanks.

Graham

PS - I originally posted this "bug" on mc-bugs on Google Groups, but maybe I should have done so here. Sorry for any confusion/duplication.

Change History

comment:1 Changed 9 years ago by angel_il

  • Owner set to angel_il
  • Status changed from new to accepted
  • Milestone changed from 4.7 to 4.7.1

comment:2 Changed 9 years ago by angel_il

  • Version changed from 4.7.0.1 to master
  • severity changed from no branch to on review

branch: 1956_last_line_problem
changeset: f3e1cd62f245fd9aa2aaf931704dcffa75afbc73

comment:3 Changed 9 years ago by andrew_b

  • Votes for changeset set to andrew_b

comment:4 Changed 9 years ago by slavazanko

  • Votes for changeset changed from andrew_b to andrew_b slavazanko
  • severity changed from on review to approved

comment:5 Changed 9 years ago by angel_il

  • Status changed from accepted to testing
  • Votes for changeset changed from andrew_b slavazanko to commited-master
  • Resolution set to fixed
  • severity changed from approved to merged

comment:6 Changed 9 years ago by angel_il

  • Status changed from testing to closed

comment:7 Changed 9 years ago by slavazanko

  • Votes for changeset changed from commited-master to commited-master commited-stable
Note: See TracTickets for help on using tickets.