Ticket #1943 (closed defect: fixed)

Opened 15 years ago

Last modified 15 years ago

mc won't compile on Solaris due to undefined constant NAME_MAX

Reported by: mcermak Owned by: andrew_b
Priority: major Milestone: 4.7.1
Component: mc-vfs Version: 4.7.0.1
Keywords: Cc:
Blocked By: Blocking:
Branch state: Votes for changeset: committed-master

Description

VFS layer (vfs/vfs.c module) references NAME_MAX symbolic constant in code dealing with charset conversions. This constant is defined on Linux but not on Solaris. This blocks building mc on (Open)Solaris systems.
However, there is another symbolic constant with same purpose - MAXNAMLEN - which is defined on Linux, Solaris and BSD systems.

Attached patch replaces NAME_MAX constant with MAXNAMLEN in vfs/vfs.c module.

Attachments

01_namelen.patch​ (1.4 KB) - added by mcermak 15 years ago.

Change History

Changed 15 years ago by mcermak

comment:1 Changed 15 years ago by andrew_b

  • Status changed from new to accepted
  • Owner set to andrew_b
  • Votes for changeset set to andrew_b
  • severity changed from no branch to on review
  • Milestone changed from 4.7 to 4.7.1

Created 1943_maxnamelen branch. Parent branch is master.
changeset:1bb8904c4e6db74cc72b49b906af62a1b1a14cc1

comment:2 Changed 15 years ago by metux

  • Votes for changeset changed from andrew_b to andrew_b metux
  • severity changed from on review to approved

comment:3 Changed 15 years ago by metux

  • Status changed from accepted to testing
  • Votes for changeset changed from andrew_b metux to committed-master
  • Resolution set to fixed

comment:4 Changed 15 years ago by metux

  • severity changed from approved to merged

comment:5 Changed 15 years ago by slavazanko

  • Status changed from testing to closed

Cherry-picked into 4.7.0-stable: 6069898e682b5bed3d7cb3e2c6a71d131ff0fb3e

Note: See TracTickets for help on using tickets.