Ticket #1935 (closed defect: fixed)

Opened 10 years ago

Last modified 10 years ago

Incorrect lock files check when hostname contains wide characters

Reported by: q0tw4 Owned by: andrew_b
Priority: minor Milestone: 4.7.1
Component: mcedit Version: master
Keywords: Cc:
Blocked By: Blocking:
Branch state: Votes for changeset: committed-master committed-stable

Description

Function lock_extract_info in file editlock.c uses number of unicode characters as number of bytes in string. I suggest to replace str_term_width1 at lines number 125 and 138 by strlen.

Change History

comment:1 Changed 10 years ago by zaytsev

Why wouldn't you provide a patch?

comment:2 in reply to: ↑ description Changed 10 years ago by andrew_b

  • Version set to master
  • Milestone set to 4.7.1

Replying to q0tw4:

Function lock_extract_info in file editlock.c uses number of unicode characters as number of bytes in string. I suggest to replace str_term_width1 at lines number 125 and 138 by strlen.

Yes, I agree. Also some optimization is required: no need to calculate string length twice.

comment:3 Changed 10 years ago by andrew_b

  • severity changed from no branch to on review

Created 1935_edit_lock_fix branch. Parent branch is master.
changeset:67c37f1d10aa12588953b41e2e070be5532e9cc1

comment:4 Changed 10 years ago by andrew_b

  • Status changed from new to accepted
  • Owner set to andrew_b

comment:5 Changed 10 years ago by metux

running through testfarm, voting if it passed.

comment:6 Changed 10 years ago by slavazanko

  • Votes for changeset set to slavazanko

comment:7 Changed 10 years ago by angel_il

  • Votes for changeset changed from slavazanko to slavazanko angel_il
  • severity changed from on review to approved

comment:8 Changed 10 years ago by andrew_b

  • Status changed from accepted to testing
  • Votes for changeset changed from slavazanko angel_il to commited-master
  • Resolution set to fixed
  • severity changed from approved to merged

comment:9 Changed 10 years ago by slavazanko

  • Status changed from testing to closed
  • Votes for changeset changed from commited-master to commited-master commited-stable
Note: See TracTickets for help on using tickets.