Ticket #1931 (closed defect: fixed)

Opened 10 years ago

Last modified 10 years ago

VFS: fixup for no-vfs builds

Reported by: metux Owned by: metux
Priority: major Milestone: 4.7.1
Component: mc-vfs Version: master
Keywords: Cc:
Blocked By: Blocking:
Branch state: Votes for changeset: committed-master

Description (last modified by metux) (diff)

This is the second take.

I'm adding several patches from #1818 and reworked a bit,
for easier review. The #1818 branch will be rebased as soon
this one is merged.

branch:1931_no_vfs_fixups

Change History

comment:1 Changed 10 years ago by metux

  • Status changed from new to accepted
  • Description modified (diff)
  • severity changed from no branch to on review

comment:2 follow-up: ↓ 3 Changed 10 years ago by andrew_b

  • Component changed from mc-core to mc-vfs

I belive that a lot of comits, realated to removed src/vfsdummy.h, can be sqaushed to single commit for easier review.

comment:3 in reply to: ↑ 2 ; follow-up: ↓ 4 Changed 10 years ago by metux

Replying to andrew_b:

I belive that a lot of comits, realated to removed src/vfsdummy.h, can be sqaushed to single commit for easier review.

I've did it this way for easier review ;-o

comment:4 in reply to: ↑ 3 ; follow-up: ↓ 5 Changed 10 years ago by andrew_b

Replying to metux:

I've did it this way for easier review ;-o

You move content of src/vfsdummy.h into vfs/vfs.h and then remove src/vfsdummy.h. I think it can be maken with single commit but not with 30 commits.

comment:5 in reply to: ↑ 4 ; follow-up: ↓ 6 Changed 10 years ago by metux

Replying to andrew_b:

Replying to metux:

I've did it this way for easier review ;-o

You move content of src/vfsdummy.h into vfs/vfs.h and then remove src/vfsdummy.h. I think it can be maken with single commit but not with 30 commits.

I did it this way, since I had been asked to do so.
Actually, if we've got some changes in vfsdummy.h before this branch is merged, we can catch it *much* easier (minimize the chance that somethings slips through).

We could squash'em together after approval, right before merge.

comment:6 in reply to: ↑ 5 Changed 10 years ago by andrew_b

  • Votes for changeset set to andrew_b
  • Milestone changed from 4.7 to 4.7.1

Replying to metux:

We could squash'em together after approval, right before merge.

OK, will not forget that.

comment:7 Changed 10 years ago by slavazanko

  • Votes for changeset changed from andrew_b to andrew_b slavazanko
  • severity changed from on review to approved

comment:8 Changed 10 years ago by andrew_b

  • Status changed from accepted to testing
  • Votes for changeset changed from andrew_b slavazanko to commited-master
  • Resolution set to fixed
  • severity changed from approved to merged

Merged to master.

git log --pretty=oneline 3e42f64..49c8644

comment:9 Changed 10 years ago by andrew_b

  • Status changed from testing to closed
Note: See TracTickets for help on using tickets.