Ticket #1918 (closed defect: fixed)

Opened 9 years ago

Last modified 9 years ago

Quick view corruption

Reported by: zaytsev Owned by: angel_il
Priority: major Milestone: 4.7.1
Component: mcview Version: master
Keywords: Cc:
Blocked By: Blocking:
Branch state: Votes for changeset: committed-master

Description

Hi!

On non UTF-8 locales (LANG=C) quick view on the left panel can become corrupted while browsing binary files.

See attached screenshots.

Attachments

scr_2833.png (47.4 KB) - added by zaytsev 9 years ago.
scr_2834.png (52.8 KB) - added by zaytsev 9 years ago.
scr_2840.png (30.3 KB) - added by zaytsev 9 years ago.

Change History

Changed 9 years ago by zaytsev

Changed 9 years ago by zaytsev

Changed 9 years ago by zaytsev

comment:1 Changed 9 years ago by zaytsev

  • Version changed from version not selected to master

comment:2 Changed 9 years ago by andrew_b

  • Milestone changed from 4.7.0.1 to 4.7

Not too easy to fix it. Moved to 4.7 milestone.

comment:3 Changed 9 years ago by andrew_b

  • Owner set to andrew_b
  • Status changed from new to accepted
  • Component changed from mc-core to mcview
  • severity changed from no branch to on review
  • Milestone changed from 4.7 to 4.7.1

Branch: 1918_quick_view_corruption. Parent branch: master.
Initial changeset:121875c21965f6654307c8979287a89e8fddb22f

Plese review.

comment:4 Changed 9 years ago by andrew_b

  • Status changed from accepted to assigned
  • Owner changed from andrew_b to angel_il

comment:5 Changed 9 years ago by angel_il

  • Votes for changeset set to angel_il

comment:6 Changed 9 years ago by slavazanko

  • Votes for changeset changed from angel_il to angel_il slavazanko
  • severity changed from on review to approved

comment:7 Changed 9 years ago by andrew_b

  • Status changed from assigned to testing
  • Votes for changeset changed from angel_il slavazanko to commited-master
  • Resolution set to fixed
  • severity changed from approved to merged

Merged to master.

git log --pretty=oneline bea2fff..9e73d2f

comment:8 Changed 9 years ago by andrew_b

  • Status changed from testing to closed

comment:9 Changed 9 years ago by slavazanko

cherry-picked and rebased into 4.7.0-stable: 029063a65bd50a6647c3e4c41724fc4b897c398a

Note: See TracTickets for help on using tickets.