Ticket #1916 (closed defect: fixed)

Opened 14 years ago

Last modified 14 years ago

VFS configure fixups

Reported by: metux Owned by: metux
Priority: major Milestone: 4.7.0.1
Component: mc-vfs Version: master
Keywords: Cc:
Blocked By: Blocking:
Branch state: Votes for changeset: committed-master

Description (last modified by metux) (diff)

  • Some long time ago, parts of MVFS development branch have been accidentially merged.
  • some AC_CONDITIONAL()'s are missing for non-vfs builds.
  • several conflicts between vfs/vfs.h and src/vfsdummy.h
  • missing functions on non-vfs builds

branch:1916_nonvfs_fixup
changeset:d8b370d973acf7ae265ab57918cb5e151ca58031

Change History

comment:1 follow-up: ↓ 3 Changed 14 years ago by andrew_b

What about #1910?

comment:2 Changed 14 years ago by andrew_b

  • Blocked By 1910 added

comment:3 in reply to: ↑ 1 Changed 14 years ago by metux

  • Status changed from new to accepted
  • Owner set to metux

Replying to andrew_b:

What about #1910?

Thats included in here.
I'm currently doing the last cleanups to get the branch ready for review.

comment:4 Changed 14 years ago by metux

  • Description modified (diff)
  • Blocked By 1910 removed
  • severity changed from no branch to on review

comment:5 follow-up: ↓ 6 Changed 14 years ago by andrew_b

  • Component changed from mc-core to mc-vfs
  • severity changed from on review to on rework

./configure --help shows

  --disable-vfs           Compile with VFS code

Should be

  --disable-vfs           Compile without VFS code

comment:6 in reply to: ↑ 5 Changed 14 years ago by metux

Replying to andrew_b:

./configure --help shows

  --disable-vfs           Compile with VFS code

Should be

  --disable-vfs           Compile without VFS code

Fixed it.

comment:7 Changed 14 years ago by metux

  • severity changed from on rework to on review

comment:8 Changed 14 years ago by slavazanko

  • Votes for changeset set to slavazanko
  • Milestone changed from 4.7 to 4.7.0.1

comment:9 Changed 14 years ago by andrew_b

  • severity changed from on review to on rework

changeset:73b2790ae7967fdebde3327a41ce0f536ca37cc4
vfs_canon_and_translate() should be rewritten using glib functions.

comment:10 Changed 14 years ago by slavazanko

  • Votes for changeset slavazanko deleted

Review, please.

comment:11 Changed 14 years ago by slavazanko

  • severity changed from on rework to on review

comment:12 Changed 14 years ago by angel_il

  • Votes for changeset set to angel_il

comment:13 Changed 14 years ago by andrew_b

  • Votes for changeset changed from angel_il to angel_il andrew_b
  • severity changed from on review to approved

Please squash 73b2790ae7967fdebde3327a41ce0f536ca37cc4 and b0e4b779e6a88d2a353289323f26b7d910d8aad0 before merge.

comment:14 Changed 14 years ago by slavazanko

  • Status changed from accepted to testing
  • Votes for changeset changed from angel_il andrew_b to commited-master
  • Resolution set to fixed
  • severity changed from approved to merged

merge changeset:00f38570e647632e1830beb93a2029d44d734c28

comment:15 Changed 14 years ago by slavazanko

  • Status changed from testing to closed
Note: See TracTickets for help on using tickets.