Ticket #1913 (closed defect: fixed)

Opened 10 years ago

Last modified 9 years ago

Warning on unused code in src/strutilutf8.c

Reported by: metux Owned by: metux
Priority: major Milestone: 4.7.0.1
Component: mc-core Version: master
Keywords: Cc:
Blocked By: Blocking:
Branch state: Votes for changeset: committed-master

Description (last modified by andrew_b) (diff)

src/strutilutf8.c defines str_utf8_key_collate(), which is never used.

This produces warnings, together w/ -Werror breaks the build.

branch:1913_unused_strfunc
changeset:caf4f5e184c72a325e56a72ba6134defd6843685

Change History

comment:1 Changed 10 years ago by metux

  • Status changed from new to accepted
  • Owner set to metux
  • Description modified (diff)
  • severity changed from no branch to on review

comment:2 Changed 10 years ago by metux

  • Version changed from version not selected to master

comment:3 Changed 10 years ago by andrew_b

  • Description modified (diff)

comment:4 follow-up: ↓ 5 Changed 10 years ago by andrew_b

Ctreating the user-defined macro started with two undelines is not a good practice.

comment:5 in reply to: ↑ 4 Changed 10 years ago by metux

Replying to andrew_b:

Ctreating the user-defined macro started with two undelines is not a good practice.

okay, feel free to change it ;-p

comment:6 Changed 10 years ago by slavazanko

  • Milestone changed from 4.7 to 4.7.0.1

review

comment:7 Changed 10 years ago by angel_il

  • Votes for changeset set to angel_il

comment:8 Changed 10 years ago by andrew_b

  • Votes for changeset changed from angel_il to angel_il andrew_b
  • severity changed from on review to approved

comment:9 Changed 10 years ago by slavazanko

  • Status changed from accepted to testing
  • Votes for changeset changed from angel_il andrew_b to commited-master
  • Resolution set to fixed
  • severity changed from approved to merged

comment:10 Changed 10 years ago by slavazanko

  • Status changed from testing to closed
Note: See TracTickets for help on using tickets.