savannah: recursive "are same file"

[ossi]

This patch solve the trouble:
1) in panel select any dir
2) F5 (copy dialog)
3) in field copy to insert "."
4) done

we have error for some file in this subdir and no way leave.

Now show dialog with [ Abort ] [ Skip ] buttons.

Original: ​http://savannah.gnu.org/bugs/?13727

Submitted by:	Oswald Buddenhagen <ossi>	Submitted on:	Mon 11 Jul 2005 03:34:08 PM UTC
Category:	Core	Severity:	3 - Normal
Status:	None	Privacy:	Public
Assigned to:	None	Open/Closed:	Open
Release:	current (CVS or snapshot)	Operating System:	All

Original submission:

recently i accidentally entered "." instead of ".." in the file 
copy dialog on a relatively big tree ... for every f***ing file in 
the tree i got the "<foo> and <bar> are the same file" message box, 
without any way to escape except killing mc from the outside. 

Comment 1 by Pavel Tsekov <ptsekov> at Tue 12 Jul 2005 11:56:05 AM UTC:

What do you think should be done in this case ?

1) Silently ignore the fact and continue

2) Pop up a box with several choices

3) Something else

Comment 2 by Oswald Buddenhagen <ossi> at Tue 12 Jul 2005 12:53:06 PM UTC:

well, one could simply do this same-inode check on directories as 
well. this would give exactly the desired effect - one error 
message box (for the top-level directory) and bye bye.

Comment 3 by Pavel Tsekov <ptsekov> at Sat 19 May 2007 01:43:08 PM UTC:

Denis Vlasenko posted a patch which would fix this issue:

http://mail.gnome.org/archives/mc-devel/2007-May/msg00033.html

[slavazanko]

patch that fix this bug

[angel_il]

last version master based

[angel_il]

created branch 19_show_abort_skip_for_copy_error; parent branch: master

[andrew_b]

src/file.c:

• modified error messages for warn_same_file() function;
• move_dir_dir(): fixed memory leak: destdir is not free'd when the same directory is copied;
• move_dir_dir(): don't use the non-valid dbuf variable if mc_stat(d, &dbuf) returns non-zero.

Fixed types of file/dir operation functions.
All po/*po files are updated to sync with modified src/file.c file.

[slavazanko]

cool. Looks good. 'Abort' action very useful in this case.
My vote here

[anonymous]

Milestone 4.6.2.1 deleted