Ticket #188 (closed enhancement: fixed)

Opened 11 years ago

Last modified 9 years ago

(mandriva) show free space

Reported by: metux Owned by: styx
Priority: major Milestone: 4.7
Component: mc-core Version: 4.6.2
Keywords: commited-master Cc:
Blocked By: Blocking:
Branch state: Votes for changeset:

Attachments

mc-show-free.patch (9.0 KB) - added by andrew_b 10 years ago.
mountlist-free_mount_list.patch (1005 bytes) - added by andrew_b 10 years ago.
Fix of memory leak in init_my_statsf()

Change History

comment:1 Changed 11 years ago by metux

  • Type changed from defect to enhancement

comment:2 Changed 10 years ago by andrew_b

I've modified this patch (see attachment). Differences:

  • info format is changed from (as an example) "5M (50%) of 10M" to " 5M/10M (50%) ". So we don't need to translate it.
  • show_free_space() function is moved from main.c to screen.c. Now this function is called in show_dir() function only. Related global variables are moved into show_free_space() and made static.

But there is a problem as in Mandriva/RH patch as in mine one. The init_my_statfs() function is called many times, therefore we have the memory leak.

Changed 10 years ago by andrew_b

comment:3 Changed 10 years ago by metux

  • Keywords vote-metux added
  • Status changed from new to accepted
  • Description modified (diff)
  • Owner set to metux

comment:4 Changed 10 years ago by andrew_b

  • Version changed from 4.6.1 to 4.6.2

I fixed memory leak in init_my_statfs() function. Patch is attached. Please review.

Changed 10 years ago by andrew_b

Fix of memory leak in init_my_statsf()

comment:5 Changed 10 years ago by metux

  • Description modified (diff)

comment:6 Changed 10 years ago by styx

I think original patch needs to be reworked. Some const's for options count like in option.c is done. Why new option has index 0? This one makes useless changes in source code. It should be with the last index...

comment:7 Changed 10 years ago by styx

my vote for mountlist-free_mount_list.patch but not for branch 188_show_free_space
Please, don't merge this into master.

comment:8 Changed 10 years ago by styx

I'll try to rework this

comment:9 Changed 10 years ago by winnie

  • Keywords rework added; review mandriva vote-metux removed

comment:10 Changed 10 years ago by styx

  • Status changed from accepted to assigned
  • Owner changed from metux to styx

comment:11 Changed 10 years ago by styx

  • Status changed from assigned to accepted

comment:12 Changed 10 years ago by styx

  • Keywords review added; rework removed

comment:13 Changed 10 years ago by metux

  • Owner changed from styx to metux
  • Description modified (diff)

comment:14 Changed 10 years ago by metux

  • Description modified (diff)

comment:15 Changed 10 years ago by styx

  • Keywords vote-styx added

comment:16 Changed 10 years ago by winnie

Why changed you the owner from styx to you? Please don't do that in future. If someone has accepted a bug he works on it.

comment:17 Changed 10 years ago by andrew_b

  • Keywords vote-andrew_b added

comment:18 Changed 10 years ago by styx

  • Status changed from accepted to assigned
  • Owner changed from metux to styx

comment:19 Changed 10 years ago by styx

  • Keywords approved commited-master added
  • Status changed from assigned to testing
  • Resolution set to fixed

comment:20 Changed 10 years ago by styx

  • Keywords review vote-styx vote-andrew_b approved removed

comment:21 Changed 10 years ago by styx

  • Status changed from testing to closed
Note: See TracTickets for help on using tickets.