Ticket #186 (closed defect: fixed)

Opened 11 years ago

Last modified 10 years ago

(mandriva) prompt fixups

Reported by: metux Owned by: slavazanko
Priority: major Milestone: 4.7.0-pre2
Component: mc-core Version: 4.7.0-pre1
Keywords: Cc:
Blocked By: Blocking:
Branch state: Votes for changeset: committed-master

Change History

comment:1 Changed 11 years ago by metux

  • Status changed from new to accepted
  • Owner set to metux
  • Milestone changed from 4.7 to 4.6.3

comment:2 Changed 11 years ago by metux

  • Description modified (diff)

comment:3 Changed 11 years ago by metux

  • Keywords vote-metux added
  • Description modified (diff)

comment:4 Changed 11 years ago by metux

  • Description modified (diff)

comment:5 Changed 11 years ago by metux

  • Description modified (diff)

comment:6 Changed 11 years ago by slyfox

What does it solve? Is it related to #213 ?

comment:7 Changed 11 years ago by winnie

I've wrote an mail to Adam, as he is the mandriva maintainer. I hope he'll add some explanations to this ticket.

comment:8 follow-up: ↓ 11 Changed 11 years ago by AdamWill

It's not actually a Mandriva patch, I took it from Fedora (if you look at the MDV spec file it's in the 'Fedora patches' section).

Here's the log from Fedora CVS:

http://cvs.fedoraproject.org/viewvc/rpms/mc/devel/mc-prompt.patch?view=log

It was initially introduced with the comment "don't print prompts multiple times when switching between mc and subshell", and later updated with the comment "fix displaying of prompt in subshell (#244025)" - that will be aRed Hat bug number, http://bugzilla.redhat.com/show_bug.cgi?id=244025 .

comment:9 Changed 11 years ago by slavazanko

  • Milestone changed from 4.6.2.1 to 4.7

comment:10 Changed 10 years ago by styx

  • Keywords vote-styx approved added; review mandriva removed
  • Status changed from accepted to assigned
  • Owner changed from metux to slyfox

comment:11 in reply to: ↑ 8 Changed 10 years ago by slyfox

Oh, thanks! I'll copy steps to reproduce here.

Original:

http://bugzilla.redhat.com/show_bug.cgi?id=244025 .

Steps to reproduce:

  1. Have a mc running where you have two different directories in each panel.
  2. Tab, so that you are in the other panel.
  3. Ctrl-O to go to subshell.
  4. You see two different prompts printed next to each other.

comment:12 Changed 10 years ago by winnie

  • Keywords vote-metux vote-styx approved removed
  • Votes for changeset set to metux, styx
  • severity set to approved

comment:13 Changed 10 years ago by slavazanko

  • Milestone changed from 4.7 to 4.7.0-pre2

comment:14 Changed 10 years ago by angel_il

  • Votes for changeset metux, styx deleted

comment:15 Changed 10 years ago by angel_il

  • severity changed from approved to on rework

comment:16 Changed 10 years ago by slavazanko

  • Owner changed from slyfox to slavazanko
  • Version changed from 4.6.1 to 4.7.0-pre1
  • Description modified (diff)

comment:17 Changed 10 years ago by slavazanko

  • severity changed from on rework to on review

Recreated branch 186_prompt_fixups (parent: master).

Initial changeset:147c3e084af04b40501ed5f923aeb01a6915cd81

Test and review, please.

comment:18 Changed 10 years ago by slavazanko

comment:19 Changed 10 years ago by slavazanko

comment:20 Changed 10 years ago by slyfox

  • Votes for changeset set to slyfox

comment:21 Changed 10 years ago by andrew_b

  • Votes for changeset changed from slyfox to slyfox andrew_b
  • severity changed from on review to approved

comment:22 Changed 10 years ago by slavazanko

  • Status changed from assigned to testing
  • Votes for changeset changed from slyfox andrew_b to commited-master
  • Resolution set to fixed
  • severity changed from approved to merged

comment:23 Changed 10 years ago by slavazanko

  • Status changed from testing to closed
Note: See TracTickets for help on using tickets.