fixing some g_malloc callsNreturn

[vit_r]

It's only pointing to start with.
For check of all calls MC-style-guider is wanted.

[andrew_b]

g_malloc() never returns NULL and aborts program on failure. g_try_malloc() should be used instead.

[vit_r]

Replying to andrew_b:

g_malloc() never ...

Great lesson !
Thanks !
Please, what about g_malloc-calls:

    mc_search_t *lc_mc_search;
    lc_mc_search = g_malloc0 (sizeof (*lc_mc_search));

g_malloc-call allows declaration 'mc_search_t *lc_mc_search; ' to be cganged
'lc_mc_search = g_malloc0 (sizeof (*lc_mc_search));' will remain the same

And in next case(from MC)

    mc_search_t *lc_mc_search;
    lc_mc_search = g_malloc0 (sizeof (mc_search_t));

both lines should be edited

To leave similar cases as they are now ?

[vit_r]

Logicall design:

if [ g_Xalloc(which failing does _NOT_ return NULL) ]; then

If (retval _IS_ checked); then

g_Xalloc is replaced by g_try_Xalloc(failing returns NULL)

fi

elif [ Xalloc(failing returns NULL) ]; then

If (retval is _NOT_ checked); then

Xalloc is replaced by g_Xalloc(failing aborts)

fi

fi

[vit_r]

For this patch is ctreated new ticket #1863

[andrew_b]

Why? What reason for that?

[vit_r]

Replying to andrew_b:

Why? What reason for that?

Because this 1857-fixing-some-g_malloc-callsNreturn.patch is wrong
As there is no possibility to remove one file then please remove 1857 ticket

If i could rename the file i would replace it then rename.

         Why  file  can  _NOT_  be deleted ?  Quit strange..

Sorry for problems

[andrew_b]

Applied in #1845.