Ticket #1844 (closed defect: fixed)

Opened 9 years ago

Last modified 9 years ago

UNneeded-goto-in-user_menu

Reported by: vit_r Owned by: andrew_b
Priority: trivial Milestone: 4.7.0
Component: mcedit Version: 4.7.0-pre4
Keywords: Cc:
Blocked By: Blocking:
Branch state: Votes for changeset: committed-master

Description (last modified by slavazanko) (diff)

simplifying the code in edit/edit.c: user_menu () {}

Attachments

1844-UNneeded-goto-in-user_menu.patch (2.2 KB) - added by vit_r 9 years ago.
only simplifying the code in edit/edit.c user_menu () {}

Change History

comment:1 Changed 9 years ago by slavazanko

  • Description modified (diff)

Please, don't use constructions like:

if (fd = fopen (block_file, "w"))

use instread:

fd = fopen (block_file, "w");
if (fd)

this much better and simplest to understood.

comment:2 Changed 9 years ago by ossi

i think the shorter version is clear enough - as long as one follows gcc's advice to put the expression into an extra pair of parentheses to avoid confusion with the == operator. whatever, not my problem ...

Changed 9 years ago by vit_r

only simplifying the code in edit/edit.c user_menu () {}

comment:3 Changed 9 years ago by vit_r

if (fd = fopen (block_file, "w")) is changed to ... if (fd)

vit_r

comment:4 Changed 9 years ago by andrew_b

  • Status changed from new to accepted
  • Owner changed from vit_r to andrew_b
  • severity changed from no branch to on review
  • Milestone changed from 4.7 to 4.7.0

Created 1844_edit_user_menu_goto_refactoring branch. Parent branch is master.
changeset:b2f4b75190de898e41b1f5487662ce684fdae185

comment:5 Changed 9 years ago by slavazanko

  • Votes for changeset set to slavazanko

comment:6 Changed 9 years ago by andrew_b

changeset:27abbb36031a7140459ac503a4ebe65c7b88bbeb -- refresh screen any way (il.smind)

comment:7 Changed 9 years ago by andrew_b

  • Votes for changeset changed from slavazanko to slavazanko andrew_b
  • severity changed from on review to approved

comment:8 Changed 9 years ago by andrew_b

  • Status changed from accepted to testing
  • Votes for changeset changed from slavazanko andrew_b to commited-master
  • Resolution set to fixed
  • severity changed from approved to merged

Merged to master.

git log --pretty=oneline f574b9b..2c7f684

comment:9 Changed 9 years ago by andrew_b

  • Status changed from testing to closed
Note: See TracTickets for help on using tickets.