Ticket #1828 (closed defect: fixed)

Opened 9 years ago

Last modified 9 years ago

Improved symlink handling in ftpfs

Reported by: zaytsev Owned by: slavazanko
Priority: major Milestone: 4.7.0
Component: mc-vfs Version: master
Keywords: Cc:
Blocked By: Blocking:
Branch state: Votes for changeset: committed-master

Description

* Improved symlink handling in ftpfs (45_ftpfs_symlink*.patch) by P.Tsekov

in the upload of this version:
mc (1:4.6.0-4.6.1-pre3-2) unstable; urgency=medium

Can this be incorporated in latest master or it does not make any sense at all? Please let me know, so that I can either remove this patch from Debian or mark it as pending for inclusion in master.

Thanks!

Attachments

01_ftpfs_symlink.patch (1.0 KB) - added by zaytsev 9 years ago.
bad_symlinks.tar.gz (421 bytes) - added by slyfox 9 years ago.
bad_symlinks.tar.gz - test sample

Change History

Changed 9 years ago by zaytsev

Changed 9 years ago by slyfox

bad_symlinks.tar.gz - test sample

comment:2 Changed 9 years ago by slyfox

bad_symlinks.tar.gz <- selfcontained example

comment:3 Changed 9 years ago by slavazanko

  • Owner set to slavazanko
  • Status changed from new to accepted

comment:4 Changed 9 years ago by slavazanko

  • severity changed from no branch to on review
  • Milestone changed from 4.7 to 4.7.0

Created branch 1828_ftpfs_improved_symlink_handling

Initial changeset:b8da312d66840f0b24ca3538c6eca8efa7f6f058

review, please.

comment:5 Changed 9 years ago by slavazanko

  • Votes for changeset set to slavazanko

comment:6 Changed 9 years ago by zaytsev

Sly wanted a better solution, did he drop this idea?

comment:7 Changed 9 years ago by slavazanko

Sly wanted a better solution, did he drop this idea?

No problem. Just recreate branch with same name and with his patches.

comment:8 Changed 9 years ago by slavazanko

  • Votes for changeset slavazanko deleted
  • severity changed from on review to on rework

As we discuss in jabber-room, patch look like a hack.

I'll try to rework...

comment:9 Changed 9 years ago by slavazanko

  • severity changed from on rework to on review

Branch fully reworked.

New initial changeset:bac7d38f4ac321c802012ea2121905f25b6b084f

review, please.

comment:10 Changed 9 years ago by slavazanko

New changesets:

Review again, please.

comment:11 Changed 9 years ago by slyfox

  • Votes for changeset set to slyfox

Not counting insane incomprehensible flag names looks at least hackable and working.
My vote.

comment:12 Changed 9 years ago by metux

  • Blocked By 1872 added

comment:13 Changed 9 years ago by slavazanko

  • Blocked By 1872 removed

comment:14 Changed 9 years ago by zaytsev

Looks good to me except for the flag names that are completely insane...

My suggestions:

CANON_PATH_MLTPLSLH -> CANON_PATH_SQUASHSLASHES / CANON_PATH_JOINSLASHES
CANON_PATH_LDTRSLHDTRM -> CANON_PATH_REMSLASHDOTS
CANON_PATH_RMDBLDT -> CANON_PATH_REMDOUBLEDOTS
CANON_PATH_DELUNC -> CANON_PATH_KEEPUNC / CANON_PATH_GUARDUNC

comment:15 Changed 9 years ago by slavazanko

review.

comment:16 Changed 9 years ago by zaytsev

  • Votes for changeset changed from slyfox to slyfox zaytsev

I like it. Thanks for your hard work, Slava!

comment:17 Changed 9 years ago by slavazanko

approved?

comment:18 Changed 9 years ago by zaytsev

  • severity changed from on review to approved

Sorry! Completely forgot about it...

comment:19 Changed 9 years ago by slavazanko

  • Status changed from accepted to testing
  • Votes for changeset changed from slyfox zaytsev to commited-master
  • Resolution set to fixed
  • severity changed from approved to merged

comment:20 Changed 9 years ago by slavazanko

  • Status changed from testing to closed
Note: See TracTickets for help on using tickets.