Ticket #1824 (closed defect: fixed)

Opened 9 years ago

Last modified 9 years ago

src_keybindC_mistakes

Reported by: vit_r Owned by: vit_r
Priority: major Milestone: 4.7.0
Component: mcedit Version: master
Keywords: Cc:
Blocked By: Blocking:
Branch state: Votes for changeset:

Description


Attachments

1824-src_keybindC_mistakes.patch (2.1 KB) - added by vit_r 9 years ago.

Change History

Changed 9 years ago by vit_r

comment:1 Changed 9 years ago by vit_r

  • Component changed from mcview to mcedit

By the way

Is this line (src/keybind.c: 669) correct:

{ XCTRL ('@'), CK_SingleDirsizeCmd, "C-Space" },

And these:
const global_keymap_t default_viewer_keymap[] = {

{ 'h', CK_ViewMoveLeft, "h" },
{ KEY_LEFT, CK_ViewMoveLeft, "Left" },

{ 'l', CK_ViewMoveRight, "l" },
{ KEY_RIGHT, CK_ViewMoveRight, "Right" },

{ 'r', CK_ViewNewBookmark, "r" },

may have a more logical look, for example :

{ 'l', CK_ViewMoveLeft, "l" },
{ KEY_LEFT, CK_ViewMoveLeft, "Left" },

{ 'r', CK_ViewMoveRight, "r" },
{ KEY_RIGHT, CK_ViewMoveRight, "Right" },

{ 'n', CK_ViewNewBookmark, "n" },

because when

'l' is CK_...Right

it puzzles, but may be some deeper reasons ... ?

comment:2 follow-up: ↓ 3 Changed 9 years ago by andrew_b

attachment 1824-src_keybindC_mistakes.patch added

Thanks! Fixed in 212_buttonbar_commands branch.

comment:3 in reply to: ↑ 2 ; follow-up: ↓ 4 Changed 9 years ago by vit_r

Replying to andrew_b:

attachment 1824-src_keybindC_mistakes.patch added

Thanks! Fixed in 212_buttonbar_commands branch.

You mean my msg has something new ?
And when 212_* will be merged to 'master' ?
For example edit.c has a lot of declarations to be corrected
like int line -> long line
but may be they are fixed already ?
The question is:
Where are fixings gathered ?

Excuse me for ignorance

Vit


comment:4 in reply to: ↑ 3 Changed 9 years ago by andrew_b

Replying to vit_r:

Replying to andrew_b:
You mean my msg has something new ?

Yes.

And when 212_* will be merged to 'master' ?

When #212 will get the second vote from one of MC developers.

For example edit.c has a lot of declarations to be corrected
like int line -> long line
but may be they are fixed already ?

No. That fixes require new ticket.

The question is:
Where are fixings gathered ?

One ticket is for one fix (or several related fixes).

comment:5 Changed 9 years ago by vit_r

Ohh ...
Great: its much more clear
Big-big THANKS

That fixes

some are on the way right now

comment:6 Changed 9 years ago by angel_il

  • Status changed from new to closed
  • Version changed from 4.7.0-pre4 to master
  • Resolution set to fixed
  • Milestone changed from 4.7 to 4.7.0

802 { KEY_F (8), CK_DeleteCmd, "F6" },

already fixed in 'master'

Note: See TracTickets for help on using tickets.