Ticket #1812 (closed task: fixed)

Opened 10 years ago

Last modified 9 years ago

Various cleanups

Reported by: metux Owned by: metux
Priority: major Milestone: 4.7
Component: mc-core Version: 4.7.0-pre4
Keywords: Cc:
Blocked By: Blocking:
Branch state: Votes for changeset:

Description


Change History

comment:1 Changed 10 years ago by metux

  • severity changed from no branch to on review

comment:2 Changed 10 years ago by metux

  • Status changed from new to accepted
  • Owner set to metux

comment:3 Changed 10 years ago by metux

comment:4 Changed 10 years ago by metux

rebased to current master

comment:5 Changed 10 years ago by metux

rebased to current master

comment:6 Changed 10 years ago by metux

please review and vote!

comment:7 Changed 10 years ago by metux

  • Milestone changed from 4.7 to 4.7.0

comment:8 Changed 10 years ago by angel_il

comment:9 Changed 10 years ago by metux

rebased on 1872_build_fixups, now passed all tests.

please vote.

comment:10 Changed 10 years ago by metux

rebase to current master, running through testfarm.

comment:11 follow-up: ↓ 13 Changed 10 years ago by slavazanko

  • severity changed from on review to on rework

I see strange picture... Look:

1780_remove_errno_decl - 49f5893c15e12465940ca3ed16b75570bbdb6b64 Removing calls of strerror() function in mc-core

1872_build_fixups - 2b58e70724169fa47edfedca937419477a8ad9c2 Removing calls of strerror() function in mc-core

Two equal commits? This my commits, but I was do it once in one branch (1780_remove_errno_decl)
What reason of duplicates?

comment:12 Changed 10 years ago by angel_il

  • Milestone changed from 4.7.0 to 4.7

comment:13 in reply to: ↑ 11 Changed 10 years ago by metux

  • severity changed from on rework to on review

Replying to slavazanko:

What reason of duplicates?

I intentionally copied it, but it doesnt hurt - if the other
branch is merged before this one, I'll rebase it (making
the commit go away).

comment:14 Changed 10 years ago by metux

  • Blocked By 1872 added

comment:15 follow-up: ↓ 16 Changed 9 years ago by slavazanko

  • severity changed from on review to on rework

Branch incompatible with current master

comment:16 Changed 9 years ago by slavazanko

  • Blocked By 1872 removed

(In #1872) Already in master

comment:16 in reply to: ↑ 15 Changed 9 years ago by andrew_b

  • Status changed from accepted to testing
  • Resolution set to fixed
  • Blocked By 1872 added

Replying to slavazanko:

Branch incompatible with current master

Partially commits of this branch are in the master one.

comment:17 Changed 9 years ago by andrew_b

  • Blocked By 1872 removed

comment:18 Changed 9 years ago by andrew_b

  • Status changed from testing to closed
Note: See TracTickets for help on using tickets.