Ticket #180 (testing defect: fixed) — at Version 6

Opened 15 years ago

Last modified 14 years ago

(mandriva) concat_dir_and_file() + NULL parameter fix

Reported by: metux Owned by: metux
Priority: major Milestone: 4.6.2
Component: mc-core Version: 4.6.1
Keywords: committed-mc-4.6 committed-master Cc:
Blocked By: Blocking:
Branch state: Votes for changeset:

Description (last modified by metux) (diff)

​http://svn.mandriva.com/cgi-bin/viewvc.cgi/packages/cooker/mc/current/SOURCES/mc-concat.patch?view=markup

branch:180_concat_dir_and_file (base mc-4.6)
changeset:54d6ec88dcb9648d77ae84d063fdaedb76233b39

committed mc-4.6
committed master

Change History

Changed 15 years ago by styx

Changed 15 years ago by styx

sorry, I'm messed up! this one should be

comment:1 Changed 15 years ago by styx

  • Keywords vote-styx added

just move patch here and make a review

comment:2 Changed 15 years ago by winnie

  • Milestone changed from 4.7 to 4.6.3

comment:3 in reply to: ↑ description Changed 15 years ago by guanx

Replying to metux:

​http://svn.mandriva.com/cgi-bin/viewvc.cgi/packages/cooker/mc/current/SOURCES/mc-concat.patch?view=markup

Here: const char *file = filename;
Why a separate variable for the filename pointer?

And, in the patch, there is this comment:
/* Is this one: *file == PATH_SEP seems to be not fully portable? */
It's also confusing.

comment:4 Changed 15 years ago by metux

  • Owner set to metux
  • Status changed from new to accepted
  • Description modified (diff)

I've reworked the whole function and replaced it by mhl_str_dir_plus_file() in mhl/string.h

comment:5 Changed 15 years ago by slyfox

  • Keywords vote-slyfox approved added; review removed

comment:6 Changed 15 years ago by metux

  • Keywords committed-mc-4.6 committed-master added; mandriva vote-styx vote-slyfox approved removed
  • Status changed from accepted to testing
  • Resolution set to fixed
  • Description modified (diff)
Note: See TracTickets for help on using tickets.