Ticket #1798 (closed defect: fixed)

Opened 9 years ago

Last modified 9 years ago

Not enough magic read before checking for lzma files

Reported by: nomis Owned by: slavazanko
Priority: major Milestone: 4.7.0
Component: mc-core Version: 4.7.0-pre4
Keywords: Cc:
Blocked By: Blocking:
Branch state: Votes for changeset: committed-master

Description

In the function get_compression_type() in src/util.c, only 5 bytes of the file are read into the magic array, but the test for lzma files checks the first 6 bytes in the magic array.

Change History

comment:1 Changed 9 years ago by slavazanko

  • Status changed from new to accepted
  • Owner set to slavazanko
  • severity changed from no branch to on review
  • Milestone changed from 4.7 to 4.7.0

Created branch 1798_fix_detect_lzma_files

Initial changeset:1b09d1be47fac957368a5db044353ac69923ac9e

Review, please.

comment:2 Changed 9 years ago by nomis

The proposed fix looks good to me.

comment:3 Changed 9 years ago by angel_il

  • Votes for changeset set to angel_il

comment:4 Changed 9 years ago by andrew_b

  • Votes for changeset changed from angel_il to angel_il andrew_b
  • severity changed from on review to approved

comment:5 Changed 9 years ago by slavazanko

  • Status changed from accepted to testing
  • Votes for changeset changed from angel_il andrew_b to commited-master
  • Resolution set to fixed
  • severity changed from approved to merged

comment:6 Changed 9 years ago by slavazanko

  • Status changed from testing to closed
Note: See TracTickets for help on using tickets.