Ticket #1784 (closed defect: fixed)

Opened 10 years ago

Last modified 10 years ago

Remove own declaration of strdup()

Reported by: metux Owned by: metux
Priority: major Milestone: 4.7
Component: mc-core Version: 4.7.0-pre4
Keywords: Cc:
Blocked By: Blocking:
Branch state: Votes for changeset: committed-master

Description (last modified by metux) (diff)

Change History

comment:1 Changed 10 years ago by metux

  • Owner set to metux
  • Status changed from new to accepted
  • Description modified (diff)
  • severity changed from no branch to on review

comment:2 Changed 10 years ago by metux

  • Description modified (diff)

comment:3 Changed 10 years ago by slavazanko

Enrico, We have plan for remove own samba-library.

We will use libsmbclient from 'samba' package (dynamically linked via dlopen/dlsym/dlclose functions). Therefore no have sence for changes into own samba-stuff.

comment:4 Changed 10 years ago by slavazanko

  • severity changed from on review to on hold

comment:5 follow-up: ↓ 7 Changed 10 years ago by metux

  • severity changed from on hold to on review

@slavo: plan != ongoing work.
there's no branch for that yet, and that will be a major change, probably not coming before 4.7.2.

so I'd really like to get my patch in.

BTW: i strongly vote against dlopen().

BTW#2: libmvfs would be a better place for the new smb client, IMHO ;-P

comment:6 Changed 10 years ago by slavazanko

  • Votes for changeset set to slavazanko

Okay, I agree with you (deplecated code != unsupported code).

comment:7 in reply to: ↑ 5 ; follow-up: ↓ 8 Changed 10 years ago by andrew_b

Replying to metux:

BTW#2: libmvfs would be a better place for the new smb client, IMHO ;-P

libmvfs? What is libmvfs? What projects use it? Google doesn't found any such projects.

libsmbclient is well-known, widely-used and well-maintained library. If you need support of Windows network on you host, you just install Samba. libsmbclient is a part of Samba project. Actually we don't need any 3rd-party library for Samba support in MC.

comment:8 in reply to: ↑ 7 Changed 10 years ago by metux

Replying to andrew_b:

libmvfs? What is libmvfs?

It's an small VFS library, which eg. supports 9P.

git://git.metux.de/libmvfs.git

libsmbclient is well-known, widely-used and well-maintained library.

Sure. But - IMHO - it seems wise to put that into libmvfs,
or better: put it into a small 9P server and let libmvfs connect it.

BTW: I'm currently in process of creating an bypass to the
traditional vfs layer (with fallback). In the end (when all
vfs'es are ported to libmvfs / 9P servers), everything can
run via libmvfs.

comment:9 follow-up: ↓ 10 Changed 10 years ago by slavazanko

comment:10 in reply to: ↑ 9 Changed 10 years ago by metux

Replying to slavazanko:

Is libmvfs better than http://library.gnome.org/devel/gio/2.22/?

It is *MUCH* smaller, similar in size like mc's internal vfs.

comment:11 follow-up: ↓ 12 Changed 10 years ago by slavazanko

It is *MUCH* smaller, similar in size like mc's internal vfs.

And this all reasons? What about 'powerfull', 'well supported', scalable' and 'stable' reasons? :)

comment:12 in reply to: ↑ 11 Changed 10 years ago by metux

Replying to slavazanko:

It is *MUCH* smaller, similar in size like mc's internal vfs.

And this all reasons?

To me, it definitivly does. I dont want the whole gnome blobs on dozens of small devices, VZs, etc just for mc.

What about 'powerfull',

What kind of power do you need from an VFS layer ?
What's missing eg. in current mc's one ?

'well supported',

What kind of support do you need ?

scalable'

What kind of scalability do you need ?
In which direction should a VFS API scale ?

libgio is full of things we most likely won't ever need.

cu

comment:13 Changed 10 years ago by metux

  • Description modified (diff)

rebased to current master

comment:14 Changed 10 years ago by andrew_b

  • Votes for changeset changed from slavazanko to slavazanko andrew_b
  • severity changed from on review to approved

comment:15 Changed 10 years ago by metux

  • severity changed from approved to merged

comment:16 Changed 10 years ago by andrew_b

  • Status changed from accepted to testing
  • Votes for changeset changed from slavazanko andrew_b to commited-master
  • Resolution set to fixed

comment:17 Changed 10 years ago by andrew_b

  • Status changed from testing to closed
Note: See TracTickets for help on using tickets.