Ticket #1771 (closed enhancement: fixed)

Opened 9 years ago

Last modified 9 years ago

Hide cursor when menu opened

Reported by: sergey-feo Owned by: andrew_b
Priority: trivial Milestone: 4.7.3
Component: mc-core Version: 4.7.0-pre4
Keywords: Cc:
Blocked By: Blocking:
Branch state: Votes for changeset: committed-master

Description

  1. Please press F9 to open menu.
  2. Open "Left" item.
  3. Item "Listing mode" will be selected. Move cursor to "FTP link" item with down arrow key.

Selected item "FTP link" is colored in 2 ways:
1) All string "FTP link" is colored;
2) First symbol "F" is colored.

I suggest disable coloring of first symbol. It make view more clear IMHO.

Please see attached screenshots also.

Attachments

with_cursor.png (6.8 KB) - added by sergey-feo 9 years ago.
without_cursor.png (6.7 KB) - added by sergey-feo 9 years ago.

Change History

Changed 9 years ago by sergey-feo

Changed 9 years ago by sergey-feo

comment:1 Changed 9 years ago by andrew_b

There is an alternative proposal: place cursor on the menu item hotkey (as in button).

comment:2 Changed 9 years ago by sergey-feo

This alternative will save unneeded additional coloring. Such coloring makes menu's view inaccurate IMHO.

comment:3 Changed 9 years ago by sergey-feo

By the way: a suggest to disable cursor on buttons too.

comment:4 Changed 9 years ago by andrew_b

  • Owner set to andrew_b
  • Status changed from new to accepted
  • Type changed from task to enhancement
  • severity changed from no branch to on review
  • Milestone changed from Future Releases to 4.7.3

Created 1771_menu_hide_cursor branch. Parent branch is master.
changeset:9139a1c9e4a35d8c2c3c7d7a65d2b5139f7b05c9

comment:5 Changed 9 years ago by angel_il

  • Votes for changeset set to angel_il

comment:6 Changed 9 years ago by slavazanko

  • Votes for changeset angel_il deleted

Branch rebased into current master and added some changes:

Review again, please.

comment:7 Changed 9 years ago by andrew_b

f5dd9b7afb990890f9a0040cbcae67049024aad2: Code cleanup for compile with -Werror option

362	 	    int i = sizeof (s_split_direction) / sizeof (char *); 
 	362	    off_t i = sizeof (s_split_direction) / sizeof (char *); 
511	 	    int i; 
 	511	    off_t i; 

Why off_t but not size_t?

comment:8 Changed 9 years ago by slavazanko

comment:9 Changed 9 years ago by andrew_b

  • Votes for changeset set to andrew_b

comment:10 Changed 9 years ago by angel_il

  • Votes for changeset changed from andrew_b to andrew_b angel_il

comment:11 Changed 9 years ago by angel_il

  • severity changed from on review to approved

comment:12 Changed 9 years ago by andrew_b

  • Status changed from accepted to testing
  • Votes for changeset changed from andrew_b angel_il to committed-master
  • Resolution set to fixed
  • severity changed from approved to merged

Merged to master.
changeset:6117c5b4ca21e53b7a97bada3c65cbb4c16a1274

git log --pretty=oneline f513925..6117c5b

comment:13 Changed 9 years ago by andrew_b

  • Status changed from testing to closed
Note: See TracTickets for help on using tickets.