Ticket #1764 (closed defect: fixed)

Opened 10 years ago

Last modified 10 years ago

No Quick view shortcut printed in menu, wrong shortcuts for File

Reported by: gotar Owned by:
Priority: trivial Milestone: 4.7.0
Component: mc-core Version: 4.7.0-pre4
Keywords: Cc:
Blocked By: Blocking:
Branch state: Votes for changeset:

Description (last modified by andrew_b) (diff)

Left/Right? menu always had "Quick view C-x q" entry, now it's only "Quick view", while the shortcut was not changed and still works.
File manu contains wrong info for:
Delete F6 instead of F8
Select group M-* instead of just "+"
Unselect group Gray+ instead of just "-"
Reverse selection Gray- instead of "*"
and
Quick cd M-c
disappeared entirely.

Change History

comment:1 in reply to: ↑ description Changed 10 years ago by andrew_b

Replying to gotar:

Left/Right? menu always had "Quick view C-x q" entry, now it's only "Quick view", while the shortcut was not changed and still works.

Unconfirmed.

File manu contains wrong info for:

Delete F6 instead of F8

Unconfirmed.

Select group M-* instead of just "+"

Unconfirmed.

Unselect group Gray+ instead of just "-"

Unconfirmed.

Reverse selection Gray- instead of "*"

Unconfirmed.

and

Quick cd M-c

disappeared entirely.

Unconfirmed.

But prefix "Gray" is correct for "Gray+", "Gray-" and "Gray*" shortcuts.

comment:2 follow-up: ↓ 3 Changed 10 years ago by gotar

I don't know how it is possible that your menu differs from mine, but "Gray" prefix although correct is simply not required as mentioned functions do work with plain [+-*].

comment:3 in reply to: ↑ 2 Changed 10 years ago by andrew_b

Replying to gotar:

I don't know how it is possible that your menu differs from mine,

Me too. Are shortcuts correct in Command menu?

but "Gray" prefix although correct is simply not required as mentioned functions do work with plain [+-*].

Ok, I'll remove "Gray" from shortcuts.

comment:4 in reply to: ↑ description Changed 10 years ago by andrew_b

  • Description modified (diff)

Replying to gotar:

Delete F6 instead of F8

You are right. This default shortcut string is wrong. But it is occured if /etc/mc/mc.keymap file is absent. Fixed in 212_buttonbar_commands branch.

Select group M-* instead of just "+"
Unselect group Gray+ instead of just "-"
Reverse selection Gray- instead of "*"

Also fixed in 212_buttonbar_commands branch.

comment:5 follow-up: ↓ 6 Changed 10 years ago by gotar

Yes, shortcuts are correct in Command menu and yes - I do all the checks with no configuration files, just plain mc binary. With mc.keymap menu indeed everything is correct.
One more mistake I haven't reported yet is "Exit C-x C-c" while only F10 exits.

comment:6 in reply to: ↑ 5 ; follow-up: ↓ 7 Changed 10 years ago by andrew_b

Replying to gotar:

One more mistake I haven't reported yet is "Exit C-x C-c" while only F10 exits.

This shortcut is present in MC code, but seems doesn't work very long time.
Fixed in 212_buttonbar_commands branch.

Great thanks!

But what about

Quick cd M-c
disappeared entirely.

comment:7 in reply to: ↑ 6 ; follow-up: ↓ 8 Changed 10 years ago by gotar

Great thanks!

You are welcome:)

But what about

Quick cd M-c
disappeared entirely.

I must have overlooked this one, it's on it's place.

And I've found similar things in editor:
File/New? C-x k instead C-n
Edit/Beginning? M-< instead C-PgUp?
Edit/End? M-> instead C-PgDn?
Search/Search? again S-F6 instead S-F7

comment:8 in reply to: ↑ 7 Changed 10 years ago by andrew_b

  • Blocked By 212 added
  • Milestone changed from 4.7 to 4.7.0

Replying to gotar:

And I've found similar things in editor:
File/New? C-x k instead C-n
Edit/Beginning? M-< instead C-PgUp?
Edit/End? M-> instead C-PgDn?
Search/Search? again S-F6 instead S-F7

Fixed in 212_buttonbar_commands branch.

comment:9 Changed 10 years ago by andrew_b

  • Blocked By 212 removed

(In #212) Merged to master.

git log --pretty=oneline 9531266..6f3b00c

comment:10 Changed 10 years ago by andrew_b

  • Status changed from new to closed
  • Resolution set to fixed

comment:11 Changed 10 years ago by andrew_b

  • severity changed from no branch to merged
Note: See TracTickets for help on using tickets.