Ticket #1743 (closed enhancement: fixed)
Allow editing large files in mcedit
| Reported by: | bilbo | Owned by: | andrew_b |
|---|---|---|---|
| Priority: | major | Milestone: | 4.8.9 |
| Component: | mcedit | Version: | 4.7.0-pre3 |
| Keywords: | Cc: | ||
| Blocked By: | Blocking: | ||
| Branch state: | merged | Votes for changeset: | committed-master |
Description
I tried to edit 68MB file, but I got message "File dump.xml is too large". I found SIZE_LIMIT in edit/edit-impl.h effectively setting max. editable file size to 64MiB.
I think this limit should be removed altogether (though it may probably need a slight rewrite of buffer system in mcedit) - computers with several gigabytes of memory are common and editing text files several hundred megabytes large is often necessary, so perhaps the only limit to size of the file should be the RAM or system architecture (approx. 2 gigabytes for 32bit systems, high enough for 64bit systems).
Change History
comment:2 Changed 14 years ago by angel_il
- Status changed from new to accepted
- Owner set to angel_il
comment:4 Changed 13 years ago by andrew_b
- Branch state set to no branch
- Milestone changed from 4.7 to Future Releases
comment:5 Changed 12 years ago by rkuzmik
guys, common :-) it is shame we need to use external editor to open large files :-(
comment:6 Changed 11 years ago by andrew_b
- Owner changed from angel_il to andrew_b
- Branch state changed from no branch to on review
- Milestone changed from Future Releases to 4.8.9
Branch: 1743_mcedit_file_size
Initial changeset:6662dc6dade4dbc4fdb9c573dcf015a717c47524
comment:8 Changed 11 years ago by angel_il
- Votes for changeset changed from slavazanko to slavazanko angel_il
- Branch state changed from on review to approved
comment:9 Changed 11 years ago by andrew_b
- Status changed from accepted to testing
- Votes for changeset changed from slavazanko angel_il to committed-master
- Resolution set to fixed
- Branch state changed from approved to merged
Merged to master: [2b0c66bc1f496bada20343823546e41e8695d7f2].
git log --pretty=oneline d38589c..2b0c66b
