Ticket #174 (closed defect: fixed)
(mandriva) set pty fd (on subshell) to closeonexec
| Reported by: | metux | Owned by: | metux |
|---|---|---|---|
| Priority: | major | Milestone: | 4.6.2 |
| Component: | mc-core | Version: | 4.6.1 |
| Keywords: | vote-winnie vote-metux committed-mc-4.6 committed-master | Cc: | |
| Blocked By: | Blocking: | ||
| Branch state: | Votes for changeset: |
Description (last modified by metux) (diff)
Patch from mandriva:
Set the subshell pty to close-on-exec
changeset:9f369abe25277eff2be9164f032c530fd425e889
--- mc-2006-11-14-16/src/subshell.c.desleak 2006-05-08 22:59:48.000000000 +0200
+++ mc-2006-11-14-16/src/subshell.c 2006-11-23 09:50:30.000000000 +0100
@@ -1150,6 +1152,7 @@
#endif /* I_FIND && I_PUSH */
#endif /* osf linux */
+ fcntl(pty_slave, F_SETFD, FD_CLOEXEC);
return pty_slave;
}
@@ -1203,6 +1207,7 @@
}
if ((pty_slave = open (pty_name, O_RDWR)) == -1)
fprintf (stderr, "open (pty_name, O_RDWR): %s\r\n", pty_name);
+ fcntl(pty_slave, F_SETFD, FD_CLOEXEC);
return pty_slave;
}
Change History
comment:2 Changed 15 years ago by winnie
- Keywords vote-winnie added
- Milestone changed from 4.7 to 4.6.2
Well.. would milestone 4.6.2 not also be okay (nevertheless the branch is already based on mc-4.6, maybe you where on the wrong branch when you created the new subbranch?).
As this is a fix and not a enhancment I would go for 4.6.2.. and nevertheless which milestone we set now.. /me votes for the patch
comment:3 Changed 15 years ago by metux
- Keywords vote-metux added
I'm fine with putting it into mc-4.6
BTW: as I'm not the author of this patch (just took it from mandriva) - is my vote valid ?
comment:4 Changed 15 years ago by winnie
Yes I would say so.
Please merge this into mc-4.6 and then into master (and please do not forget a changelog entry).
comment:5 Changed 15 years ago by metux
- Owner set to metux
- Keywords committed-mc-4.6 committed-master added; review removed
- Status changed from new to accepted
