Ticket #172 (closed task: fixed)

Opened 11 years ago

Last modified 9 years ago

Use 'indent' utility

Reported by: slavazanko Owned by: slavazanko
Priority: minor Milestone: 4.7.1
Component: adm Version: 4.6.1
Keywords: Cc:
Blocked By: Blocking:
Branch state: Votes for changeset: committed-master committed-stable

Description (last modified by angel_il) (diff)

I propose use indent utility before commits.

Options to indent:

indent \
  	--gnu-style 
 	--format-first-column-comments 
 	--indent-level4 
 	--brace-indent0 
 	--line-length100 
 	--no-tabs 
 	--blank-lines-after-procedures 

or

indent -gnu -fc1 -i4 -bli0 -nut -bap -l100

See also attach (git-ci). This script will help with automate indentation before commits.

Attachments

git-ci (495 bytes) - added by slavazanko 11 years ago.
helper for indent before git-commit

Change History

Changed 11 years ago by slavazanko

helper for indent before git-commit

comment:1 Changed 10 years ago by styx

may be it will be better to use spaces instead of tabs?
and what about stuff we already have commited?
I think, trailing spaces can&must be killed :-E
Space+Tabs hell is awful shoud be some thing one at list.

P.S. I vote for spaces (:

comment:2 Changed 10 years ago by angel_il

please, vote for this stile:

indent -br -ce -cli0 -cbi0 -sai --indent-level4 -nut --line-length185

comment:3 Changed 10 years ago by angel_il

or
indent -brs -br -ce -cli0 -cbi0 -sai -i4 -nut -l100

comment:4 Changed 10 years ago by angel_il

  • Priority changed from major to minor
  • Component changed from mc-core to adm
  • Milestone 4.7 deleted

comment:5 Changed 10 years ago by styx

  • Milestone set to future releases

comment:6 Changed 9 years ago by slavazanko

  • Status changed from new to accepted
  • Owner set to slavazanko
  • severity set to on review
  • Milestone changed from Future Releases to 4.7.1

Created branch 172_indent (parent: master)

Initial changeset:fbc5c4ee01907fb5d4e6032d116acfde1082f321

Review, please.

comment:7 Changed 9 years ago by angel_il

  • Votes for changeset set to angel_il

comment:8 Changed 9 years ago by andrew_b

  • Votes for changeset changed from angel_il to angel_il andrew_b

comment:9 Changed 9 years ago by styx

  • Votes for changeset changed from angel_il andrew_b to angel_il andrew_b styx

comment:10 Changed 9 years ago by slavazanko

  • Status changed from accepted to testing
  • Votes for changeset changed from angel_il andrew_b styx to commited-master commited-stable
  • Resolution set to fixed
  • severity changed from on review to merged

comment:11 Changed 9 years ago by slavazanko

  • Status changed from testing to closed

comment:12 Changed 9 years ago by angel_il

  • Description modified (diff)

comment:13 Changed 9 years ago by angel_il

  • Description modified (diff)
Note: See TracTickets for help on using tickets.