Ticket #1708 (closed defect: fixed)

Opened 10 years ago

Last modified 10 years ago

ftp permission

Reported by: x905 Owned by: slavazanko
Priority: major Milestone: 4.7.0
Component: mc-vfs Version: 4.7.0-pre3
Keywords: Cc:
Blocked By: Blocking:
Branch state: Votes for changeset: committed-master

Description

then i copy file to ftp - mc still try to set permissions because "preserve Attributes" set (as default) - why ?

Change History

comment:1 Changed 10 years ago by zaytsev

And why wouldn't it?

comment:2 Changed 10 years ago by x905

because ftp dont have attributes
in previous builds (for example "4.6.3-r529") mc works as expected - dont try to set unsettable attribute

comment:3 Changed 10 years ago by x905

please accept this ticket - its very annoying bug

comment:4 Changed 10 years ago by slavazanko

  • Status changed from new to accepted
  • Owner set to slavazanko

comment:5 Changed 10 years ago by slavazanko

  • Component changed from mc-core to mc-vfs
  • severity changed from no branch to on review
  • Milestone changed from 4.7 to 4.7.0

Created branch 1708_ftp_permission

Initial changeset:74815e7a2210a4ebe572f15d84def3b0ec60986d

Review, please.

comment:6 Changed 10 years ago by x905

works ok

comment:7 Changed 10 years ago by zaytsev

Ah, I see what you meant to say now. Actually it should, since FTP DOES have attributes, but it shouldn't warn you about errors if ignore_ftp_chattr_errors is set.

This change obsoletes 02_ignore_ftp_chmod_error.patch , just a note to myself.

comment:8 Changed 10 years ago by iNode

  • Votes for changeset set to iNode

comment:9 Changed 10 years ago by metux

  • Votes for changeset changed from iNode to iNode metux

we probably need some generic solution.

a similar problem happens when copying files to a fat-fs.

comment:10 Changed 10 years ago by metux

  • severity changed from on review to approved

comment:11 Changed 10 years ago by slavazanko

  • Status changed from accepted to testing
  • Votes for changeset changed from iNode metux to commited-master
  • Resolution set to fixed
  • severity changed from approved to merged

comment:12 Changed 10 years ago by slavazanko

  • Status changed from testing to closed
Note: See TracTickets for help on using tickets.