Ticket #1667 (closed defect: fixed)

Opened 10 years ago

Last modified 9 years ago

Hardcoded colours

Reported by: gotar Owned by: slavazanko
Priority: minor Milestone: 4.7.0-pre4
Component: mcedit Version: 4.7.0-pre3
Keywords: Cc:
Blocked By: Blocking:
Branch state: Votes for changeset: committed-master

Description

BOOK_MARK_COLOR and BOOK_MARK_FOUND_COLOR are hardcoded in edit/edit-widget.h and so cannot be changed via skin.

Change History

comment:1 Changed 10 years ago by slavazanko

  • Owner set to slavazanko
  • Status changed from new to accepted
  • Milestone changed from 4.7 to 4.7.0-pre4

comment:2 Changed 10 years ago by slavazanko

related bug: #1559

comment:3 Changed 10 years ago by slavazanko

  • severity changed from no branch to on review

created branch 1667_hardcoded_colors

initial changeset:48cb06c1b7e324728c16901a580e478b9f3c6d9e

Review, please.

comment:4 Changed 10 years ago by iNode

Isn't should be default values specified?
(or 0 is correct default value?)

comment:5 Changed 10 years ago by slavazanko

if no any values specified, then this is equal to [section_name]._default_

In this case, these colorpairs will equal to editor._default_ (lightgray;blue)

comment:6 Changed 10 years ago by angel_il

  • Votes for changeset set to angel_il

initial: 873de2390ddd863e0a7ec4fbab784446b630ff06 (forced update)

comment:7 Changed 10 years ago by slavazanko

Review, please.

comment:8 Changed 10 years ago by andrew_b

  • Votes for changeset changed from angel_il to angel_il andrew_b
  • severity changed from on review to approved

comment:9 Changed 10 years ago by slavazanko

  • Status changed from accepted to testing
  • Votes for changeset changed from angel_il andrew_b to commited-master
  • Resolution set to fixed
  • severity changed from approved to merged

comment:10 Changed 10 years ago by slavazanko

  • Status changed from testing to closed
Note: See TracTickets for help on using tickets.