Ticket #1634 (closed defect: fixed)

Opened 9 years ago

Last modified 8 years ago

DEL & END keys dialog binding

Reported by: theMIROn Owned by: angel_il
Priority: major Milestone: 4.8.0-pre1
Component: mc-tty Version: master
Keywords: Cc: zaytsev
Blocked By: Blocking:
Branch state: Votes for changeset: committed-master committed-stable

Description (last modified by andrew_b) (diff)

Currently DEL & END keys misprocessed in all dialogs.
Keys check from menu works fine at the same time.
TERM=linux
CP866 (IBM866) locale

Attachments

hotkeys.diff (1.3 KB) - added by theMIROn 9 years ago.

Change History

comment:1 Changed 9 years ago by theMIROn

  • Priority changed from major to critical

comment:2 Changed 9 years ago by angel_il

  • Priority changed from critical to minor

comment:3 Changed 9 years ago by theMIROn

DEL is working, but BackSpace? is not.

comment:4 Changed 9 years ago by theMIROn

any news?
hotkeys are not treated as unicode, that's the problem

comment:5 Changed 9 years ago by theMIROn

  • Priority changed from minor to major

comment:6 Changed 9 years ago by andrew_b

  • Component changed from mc-core to mc-tty

Changed 9 years ago by theMIROn

comment:7 follow-up: ↓ 8 Changed 9 years ago by theMIROn

g_ascii_tolower strips unicode key param, moreover, don't reflect actual label text encoding.
following patch fixes hotkeys on 8bit locale

comment:8 in reply to: ↑ 7 ; follow-up: ↓ 9 Changed 9 years ago by andrew_b

  • Description modified (diff)

Replying to theMIROn:

g_ascii_tolower strips unicode key param,

Actually, param in not unicode. Multibyte hotkeys are not correctly constuct in handling of tty key events.

following patch fixes hotkeys on 8bit locale

I'm not shure that it is correct way. Your patch breaks case-insensitive hotkeys.

comment:9 in reply to: ↑ 8 Changed 9 years ago by theMIROn

Replying to andrew_b:

following patch fixes hotkeys on 8bit locale

I'm not shure that it is correct way. Your patch breaks case-insensitive hotkeys.

it's already deeply broken for all non-ascii localies
patch doesn't add different localies support, but fix the behaviour

comment:10 Changed 8 years ago by zaytsev

  • Cc zaytsev added

Isn't there a lowercase routine which works with unicode characters?

comment:11 Changed 8 years ago by angel_il

  • Owner set to angel_il
  • Status changed from new to accepted

comment:12 Changed 8 years ago by angel_il

  • severity changed from no branch to on review

comment:13 Changed 8 years ago by andrew_b

  • Votes for changeset set to andrew_b
  • Milestone changed from 4.7 to 4.8.0-pre1

comment:14 Changed 8 years ago by slavazanko

  • Votes for changeset changed from andrew_b to andrew_b slavazanko
  • severity changed from on review to approved

comment:15 Changed 8 years ago by angel_il

is this a stable candidate?

comment:16 Changed 8 years ago by angel_il

  • Status changed from accepted to testing
  • Votes for changeset changed from andrew_b slavazanko to committed-master
  • Resolution set to fixed
  • severity changed from approved to merged

comment:17 Changed 8 years ago by andrew_b

  • Status changed from testing to closed
  • Votes for changeset changed from committed-master to committed-master committed-stable
Note: See TracTickets for help on using tickets.