Ticket #1609 (closed defect: fixed)

Opened 10 years ago

Last modified 9 years ago

copy/move mangles invalid utf8 filename

Reported by: egmont Owned by: andrew_b
Priority: minor Milestone: 4.7.0-pre4
Component: mc-core Version: 4.7.0-pre2
Keywords: Cc:
Blocked By: Blocking:
Branch state: Votes for changeset: committed-master

Description

Fully UTF-8 environment, mc working in UTF-8 mode. MC displays filenames containing invalid UTF-8 sequences using U+FFFD - correct.

If I copy or move this file to another directory (e.g. simply F5 Enter or F6 Enter to copy/move to the other panel), the filename gets mangled, invalid UTF-8 characters are replaced by literal question marks.

Copy/move should leave the filename unchanged, even if it is invalid in the locale mc's using for display.

(Filesystem is some Linux fs (e.g. ext3) with Posix semantics so that filename is a sequence of bytes, interpretation up to the application. Obviously this bug cannot occur if the source filesystem has Windows semantics - filename is sequence of characters. Obviously the filename does have to mangled when copying from Posix to Windows semantics filesystem.)

Bug present in 4.7.0-pre2 as well 4.6.x+utf8 patches.

Change History

comment:1 Changed 10 years ago by andrew_b

  • Owner set to andrew_b
  • Status changed from new to accepted
  • severity changed from no branch to on review
  • Milestone changed from 4.7 to 4.7.0-pre4

Created branch 1609_dont_fix_dest_filename.
1st changeset:0c96e17461ba7c52fabb421ca93f62bccd5118d3 -- minor refactoring
2nd changeset:9d065f65c997e0fac1934788d171c689d41e656c -- bug fix

Please review and vote.

comment:2 Changed 10 years ago by slavazanko

  • Votes for changeset set to slavazanko

comment:3 Changed 10 years ago by angel_il

  • Votes for changeset changed from slavazanko to slavazanko angel_il
  • severity changed from on review to approved

comment:4 Changed 10 years ago by andrew_b

  • Status changed from accepted to testing
  • Votes for changeset changed from slavazanko angel_il to commited-master
  • Resolution set to fixed
  • severity changed from approved to merged

Merged to master.

git log --pretty=oneline 551ca67..6d4d1e9

comment:5 Changed 10 years ago by andrew_b

  • Status changed from testing to closed
Note: See TracTickets for help on using tickets.