Ticket #1607 (closed defect: fixed)

Opened 10 years ago

Last modified 9 years ago

undelfs check broken in configure(.ac)

Reported by: olfway Owned by: slavazanko
Priority: major Milestone: 4.7.0-pre4
Component: mc-core Version: 4.7.0-pre2
Keywords: Cc:
Blocked By: Blocking:
Branch state: Votes for changeset: committed-master

Description (last modified by andrew_b) (diff)

$./configure --with-screen=ncurses --disable-vfs-undelfs
$fgrep 'USE_UNDEL_FS' config.status
S["USE_UNDEL_FS_FALSE"]="#"
S["USE_UNDEL_FS_TRUE"]=""

it it will tries to build undelfs vfs even if you specify --disable
configure.ac:
AM_CONDITIONAL(USE_UNDEL_FS, [test -n "$enable_vfs_undelfs"])
should be replaced with
AM_CONDITIONAL(USE_UNDEL_FS, [test x"$enable_vfs_undelfs" = xyes])

Change History

comment:1 Changed 10 years ago by iNode

It's disabled by default. Why you need --disable-vfs-undelfs?

comment:2 Changed 10 years ago by slavazanko

  • Owner set to slavazanko
  • Status changed from new to accepted
  • severity changed from no branch to on review

Created branch 1607_undel_fs

Initial changeset:c29abefe0c5b1c5e58a401f4edd072f3d09b7f32

review

comment:3 Changed 10 years ago by olfway

i'm compiling it with "gentoo-prefix" on osx, there is line in ebuild:
$(use_enable kernel_linux vfs-undelfs)
that translates into --enable-vfs-undelfs if you have linux kernel and to --disable-vfs-undelfs if you don't

comment:4 Changed 10 years ago by andrew_b

  • Description modified (diff)

comment:5 Changed 10 years ago by iNode

  • Votes for changeset set to iNode

comment:6 Changed 10 years ago by slavazanko

  • Votes for changeset changed from iNode to iNode slavazanko
  • severity changed from on review to approved

comment:7 Changed 10 years ago by slavazanko

  • Status changed from accepted to testing
  • Votes for changeset changed from iNode slavazanko to commited-master
  • Resolution set to fixed
  • severity changed from approved to merged
  • Milestone changed from 4.7 to 4.7.0-pre4

comment:8 Changed 10 years ago by slavazanko

  • Status changed from testing to closed
Note: See TracTickets for help on using tickets.