Ticket #1604 (closed defect: fixed)

Opened 10 years ago

Last modified 9 years ago

Broken i18n support of CP866 locale

Reported by: theMIROn Owned by: andrew_b
Priority: critical Milestone: 4.7.0-pre3
Component: mc-core Version: master
Keywords: Cc:
Blocked By: Blocking:
Branch state: Votes for changeset: committed-master

Description

I have Debian Lenny 5.02 inside coLinux with colinux-nt-console.
The only nt-console supported charset is CP866, and seems like mc support is broken. Debian's console utils and mc 4.6.3 works fine with this locale.
Dialog messages,hints, helps, etc are all shown as question marks, even display charset was set to CP866. Moreover, display charset changes doesn't make a sense, question chars are always here, no matter within console or putty, CP1251/KOI8-R works via ssh at the same time.

colinux:~# LC_ALL=C mc -V
GNU Midnight Commander 4.7.0-pre2-43-g956d356
Virtual File System: tarfs, extfs, cpiofs, ftpfs, fish
With builtin Editor
Using system-installed S-Lang library with terminfo database
With subshell support as default
With support for background operations
With mouse support on xterm
With internationalization support
With multiple codepages support
Data types: char 8 int 32 long 32 void * 32 off_t 64 ecs_char 32
colinux:~# LC_ALL=ru_RU.CP866 mc -V
GNU Midnight Commander, версия 4.7.0-pre2-43-g956d356
Виртуальная файловая система: tarfs, extfs, cpiofs, ftpfs, fish
Со встроенным редактором
С установленной в системе библиотекой S-Lang с базой данных terminfo
C поддержкой внутренней командной оболочки
С поддержкой фоновых операций
С поддержкой мыши в xterm
С поддержкой интернационализации
С поддержкой многих кодировок
Data types: char 8 int 32 long 32 void * 32 off_t 64 ecs_char 32
colinux:~# cat /usr/local/share/i18n/SUPPORTED
ru_RU.CP866 IBM866
colinux:~# locale -a
C
POSIX
ru_RU.cp866
colinux:~# locale
LANG=ru_RU.CP866
LC_CTYPE="ru_RU.CP866"
LC_NUMERIC="ru_RU.CP866"
LC_TIME="ru_RU.CP866"
LC_COLLATE="ru_RU.CP866"
LC_MONETARY="ru_RU.CP866"
LC_MESSAGES="ru_RU.CP866"
LC_PAPER="ru_RU.CP866"
LC_NAME="ru_RU.CP866"
LC_ADDRESS="ru_RU.CP866"
LC_TELEPHONE="ru_RU.CP866"
LC_MEASUREMENT="ru_RU.CP866"
LC_IDENTIFICATION="ru_RU.CP866"
LC_ALL=

screenshot attached

Attachments

165lll.png (50.6 KB) - added by theMIROn 10 years ago.
i18n cp866 bug

Change History

Changed 10 years ago by theMIROn

i18n cp866 bug

comment:1 Changed 10 years ago by theMIROn

no news so far?

comment:2 Changed 10 years ago by theMIROn

  • Version changed from 4.7.0-pre2 to master

comment:3 Changed 10 years ago by andrew_b

  • Owner set to andrew_b
  • Status changed from new to accepted
  • severity changed from no branch to on review
  • Milestone changed from 4.7 to 4.7.0-pre3

Created 1604_cp866 branch. Parent branch: master.
1st changeset:4e38a3ead004f7f66d3897cd864d759360d40705
2nd changeset:9aceaf641805250f5755ec5521aa88518ab0ac23

Please review.

comment:4 Changed 10 years ago by angel_il

  • Votes for changeset set to angel_il

comment:5 Changed 10 years ago by slavazanko

  • Votes for changeset changed from angel_il to angel_il slavazanko
  • severity changed from on review to approved

Looks good. Now works correctly with ibm-866 codepage.

Vote here.

comment:6 Changed 10 years ago by theMIROn

  • Votes for changeset changed from angel_il slavazanko to angel_il slavazanko theMIROn

thmx, works great.
btw, was it really intended to remove setup_dummy_mc() within mc_maybe_editor_or_viewer() func, but to leave done_mc()?

comment:7 Changed 10 years ago by andrew_b

  • Status changed from accepted to testing
  • Votes for changeset changed from angel_il slavazanko theMIROn to commited-master
  • Resolution set to fixed
  • severity changed from approved to merged

comment:8 Changed 10 years ago by andrew_b

  • Status changed from testing to closed
Note: See TracTickets for help on using tickets.