Ticket #160 (closed enhancement: fixed)

Opened 11 years ago

Last modified 9 years ago

[PATCH] Edit: ebuild syntax definition

Reported by: Enrico.Weigelt@…> Owned by: metux
Priority: major Milestone: 4.7
Component: mcedit Version: 4.6.1
Keywords: committed-master Cc:
Blocked By: Blocking:
Branch state: Votes for changeset:

Description (last modified by slavazanko) (diff)

Adding Gentoo eBuild syntax definition.

changeset:5471443eeacb91322fb7488bcd24b4eb6a609317

Attachments

syntax-ebuild.001.diff (4.5 KB) - added by anonymous 11 years ago.
Added by email2trac
0001-syntax-ebuild.syntax-new-syntax-file-based-on-sh.sy.patch (11.0 KB) - added by slyfox 11 years ago.

Change History

Changed 11 years ago by anonymous

Added by email2trac

comment:1 Changed 11 years ago by anonymous

  • id set to 160

This message has 1 attachment(s)

comment:2 Changed 11 years ago by winnie

  • Status changed from new to assigned
  • Keywords review added
  • Description modified (diff)
  • Owner set to metux

I reassign this to you as you created the branch 160_syntax_ebuild which contains the attached fix. See b0243d50783ad78995909f354e25db204c2d8af7 and 3906a150e6cd400e9508309c947b3f235d776b72 for details.

comment:3 Changed 11 years ago by winnie

  • Keywords vote-test added

Playing around with the default queries.. in order to test if a modified query works I need a dummy vote-user tag...

comment:4 Changed 11 years ago by winnie

  • Keywords vote-winnie added

Adding my vote for testing purposes.. will remove it later

comment:5 Changed 11 years ago by winnie

  • Keywords vote-test vote-winnie removed

removed testing stuff

comment:6 Changed 11 years ago by Enrico Weigelt

  • MC Ticket System <tickets@…> schrieb:

Playing around with the default queries.. in order to test if a modified
query works I need a dummy vote-user tag...

hmm, can you set up an query which shows all with at least two
votes ?

cu

comment:7 Changed 11 years ago by metux

  • Status changed from assigned to accepted
  • Type changed from defect to enhancement
  • Component changed from mc-core to mcedit
  • Description modified (diff)

comment:8 Changed 11 years ago by winnie

As I'm not familiar with ebuild at all I can't say anything to the syntaxfile.. from the layout and etc. it looks good but if this file makes sense with these keywords.. I don't know.

Can please someone who knows ebuild files review this ticket please? If there is only one vote in the next week please add a vote-winnie as I think this file will be correct and I doesn't want to stand in the way to get this new syntaxfile into mc.

comment:9 Changed 11 years ago by slavazanko

I'm Red Hat man, and don't know is keywords valid or not too. But syntax-files not important for evolve development, IMHO.

Propose: syntax-related patches may apply without vote (or with one vote only).

comment:10 Changed 11 years ago by winnie

No.. every patch should need two votes.. if there are special cases (like this patch) it might be okay if someone who knows the ebuild syntax well can apply it without getting two votes..

As this patch seems to be okay from the "looks good standpoint" feel free to commit w/o my vote.

comment:11 Changed 11 years ago by slyfox

  • Keywords review, ebuild added; review removed

.ebuilds are usual shell scripts

Ebuild syntax file looks _OUTDATED_ in respect to shell.syntax with:

shell out-of-sync issues:

  • some control words are hot highlighted: 'if', 'then', 'else', etc. (have a look at 'diff syntax/ebuild.syntax syntax/shell.syntax')
  • some literals are not highlighted:
    • single quoted ones: """sed -e -s's/hello/world/g'"""
    • global variables: """AUDIO="$(get_audio)"""
  • some global vars are not highlighted properly: SCR_URI, SLOT
  • some ebuild keywords are not highlighted at all: 'enewgroup'

All the rest looks OK, so patch could be merged. I could add some patches to fix above issues this weekend :]

comment:12 Changed 11 years ago by winnie

  • Keywords rework added; review, ebuild removed

Hey Slyfox,

It would be cool if you could send us a patch which is based on the 160_syntax_ebuild branch. Then we could directly add your patch there.

As you say that this patch is not fully okay I set keyword to "rework" until this is fixed.

Thanks for your help.

comment:13 Changed 11 years ago by slyfox

  • Keywords review added; rework removed

Done.

0001-syntax-ebuild.syntax-new-syntax-file-based-on-sh.sy.patch

feel free to git-apply it on top of 160_syntax_ebuild branch

comment:14 Changed 10 years ago by slavazanko

patch 0001-syntax-ebuild.syntax-new-syntax-file-based-on-sh.sy.patch applied to '160_syntax_ebuild' branch. See changeset:3bc655a89b326f3e8128a3805a06f7bf73caa467

Please, review someone who familiar with Gentoo :)

feel free to git-apply it on top of 160_syntax_ebuild branch

As I see, git-am better utility for applying patches like your patch :)

comment:15 Changed 10 years ago by slavazanko

  • Status changed from accepted to testing
  • Keywords committed-master added; review removed
  • Resolution set to fixed
  • Description modified (diff)

Branch '160_syntax_ebuild' merged to master.

Branch '160_syntax_ebuild' deleted.

comment:16 Changed 10 years ago by winnie

  • Status changed from testing to closed

Closing

Note: See TracTickets for help on using tickets.