Ticket #1596 (closed enhancement: fixed)

Opened 10 years ago

Last modified 9 years ago

hidden file highlighing

Reported by: slyfox Owned by: iNode
Priority: major Milestone: 4.7.0-pre3
Component: mc-core Version: master
Keywords: settings Cc:
Blocked By: Blocking:
Branch state: Votes for changeset: committed-master

Description (last modified by iNode) (diff)

Would be cool to have tick "disable highlighting" for .hidden files Options->Layout->Highlight and/or get sane color for files of such type.

Just have a look at default mc: http://trofimeus.narod.ru/2009-09-09-21-02-56.png

Change History

comment:1 follow-up: ↓ 2 Changed 10 years ago by iNode

  • Keywords settings added

What color do you propose?

p.s. your blue color in terminal is not default and in your case you can redifine also black color.

comment:2 in reply to: ↑ 1 Changed 10 years ago by slyfox

Replying to iNode:

What color do you propose?

Have no any preferences. It is perfect for me to have them unhilighted.

p.s. your blue color in terminal is not default and in your case you can redifine also black color.

Yep, it's not vanilla xterm's color scheme. It is stolen from an old Alt Master linux distro.
Tried default vte terminal. I would not call that readable: http://trofimeus.narod.ru/2009-09-10-21-44-58.png [300KB]

comment:3 Changed 10 years ago by iNode

  • Status changed from new to accepted
  • Owner set to iNode
  • severity changed from no branch to on rework
  • Summary changed from panel: sane/disableable hilight of .dot-started files to hidden file higlighing

branch: 1596_file_higlighing (parent: master)
changeset: 28533957761f2e62f9f5c211c37ef658da430a24

remove hightlight for hidden, extend and fix templates for hightlight

comment:4 Changed 10 years ago by iNode

  • severity changed from on rework to on review
  • Description modified (diff)
  • Summary changed from hidden file higlighing to hidden file highlighing

comment:5 Changed 10 years ago by slyfox

  • Votes for changeset set to slyfox

Thanks! It looks much better that way.

comment:6 Changed 10 years ago by slavazanko

  • Votes for changeset changed from slyfox to slyfox slavazanko
  • severity changed from on review to approved

Actually, I'm disagree with this patch: external rules for highlighting of file names was created for changes by users, not for changes in repo :). But before pre3 we may change content if filehighlight.ini, therefore my vote here.

comment:7 Changed 10 years ago by iNode

Isn't we should provide usable defaults?

comment:8 Changed 10 years ago by iNode

  • Status changed from accepted to testing
  • Votes for changeset changed from slyfox slavazanko to commited-master
  • Resolution set to fixed
  • severity changed from approved to merged

comment:9 Changed 10 years ago by iNode

  • Status changed from testing to closed
Note: See TracTickets for help on using tickets.