Ticket #1582 (closed defect: fixed)

Opened 9 years ago

Last modified 9 years ago

Screen flickering on updates

Reported by: vda Owned by: andrew_b
Priority: major Milestone: 4.7.0-pre3
Component: mc-core Version: 4.7.0-pre2
Keywords: Cc: b0ntrict0r@…
Blocked By: Blocking:
Branch state: Votes for changeset: committed-master

Description

I rebuilt mc from Aug 19 2009 git and I see
a somewhat subtle effect.

On screen updates, mc now "flickers".

The simplest way to see it is to open a large xterm window
with mc file view (it is less noticeable on text consoles),
press and hold Ctrl-R (refresh).

In mc built from git a month ago or so, or in some old releases,
nothing noticeable happens. In new mc, I see cursor appearing
randomly in the panel, with the rest of line after cursor cleared
and painted black. It happens on random lines and quickly disappears
and reappears. It happens so often and takes so much time
that Ctrl-R redraw cannot keep up with keyboard repeat -
I release the keys but redraws continue for several seconds.

This effect is not limited to Ctrl-R, it's just the easiest way to see it.
I see it all the time when screen is updated. For example,
if I stand on a text file and press F4, Esc, F4, Esc repeatedly.
And I do not see it with old mc in this case too.

Does anybody else see this?

Change History

comment:1 Changed 9 years ago by rt

  • Cc b0ntrict0r@… added

Meseems I alway saw it.

comment:2 Changed 9 years ago by andrew_b

  • Owner set to andrew_b
  • Status changed from new to accepted
  • Milestone changed from 4.7 to 4.7.0-pre3

It's a result of changeset:4e40f6e98f2036cc8893e581cf52cdf5c239064e.

diff --git a/src/main.c b/src/main.c
index d9cd68e..51d84ce 100644
--- a/src/main.c
+++ b/src/main.c
@@ -531,6 +531,7 @@ void
 repaint_screen (void)
 {
     do_refresh ();
+    tty_touch_screen ();
     tty_refresh ();
 }

comment:3 Changed 9 years ago by andrew_b

  • severity changed from no branch to on review

Created branch 1582_repaint_screen. Parent branch: master.
changeset:e3684f3379fb10902019395bd930a52bbe082cc7
Please test.

comment:4 Changed 9 years ago by angel_il

  • Votes for changeset set to angel_il

comment:5 Changed 9 years ago by slavazanko

  • Votes for changeset changed from angel_il to angel_il slavazanko
  • severity changed from on review to approved

comment:6 Changed 9 years ago by andrew_b

  • Status changed from accepted to testing
  • Votes for changeset changed from angel_il slavazanko to commited-master
  • Resolution set to fixed
  • severity changed from approved to merged

comment:7 Changed 9 years ago by andrew_b

  • Status changed from testing to closed
Note: See TracTickets for help on using tickets.