mc segfaults when you try to use non-anonymous FTP

[zaytsev]

Hi!

When you try to login using FTP as a not anonymous user (e.g. user@host) mc segfaults as you enter the address and the username. This became broken very recently, mc build from one week ago worked just fine.

dbg backtraces:

​http://www.nopaste.com/p/aG06r983bb
​http://www.nopaste.com/p/aeQhfJPfO

[iNode]

Should we init def_text by NULL instead of ((char*) -1)?

initial_buffer_len = 1 + max ((size_t) width, strlen (def_text));
// strlen((char*) -1); it's isn't correct 

[iNode]

diff --git a/src/wtools.h b/src/wtools.h
index 1fc45ad..5e71949 100644
--- a/src/wtools.h
+++ b/src/wtools.h
@@ -172,7 +172,7 @@ int quick_dialog_skip (QuickDialog *qd, int nskip);
 /* The input dialogs */
 
 /* Pass this as def_text to request a password */
-#define INPUT_PASSWORD ((char *) -1)
+#define INPUT_PASSWORD ((char *) NULL)
 
 char *input_dialog (const char *header, const char *text,
                    const char *history_name, const char *def_text);

[zaytsev]

Thanks!!! Attached patch works for me. Will vote for inclusion as soon as a branch is created.

[iNode]

It was just workaround. It works but it's invalid because it's allow save input password in history. Please clean manually your history if you use it.

branch:1580_ftp_input_password (parent:master)
changeset: 40057ff3a66b39cdb03c772f43b847ae0b05847d

[iNode]

fixed: e05778a4e4c2dd85776f6b6f85ac51a19a9cd326

[iNode]

The same branch, please review:

99d02797923e340b5771cf14150ff8ee0b1c20a1

[iNode]

fixed: 956d356a01e073c0e7a6354def8e12228896f5ec