Ticket #1580 (closed defect: fixed)

Opened 10 years ago

Last modified 9 years ago

mc segfaults when you try to use non-anonymous FTP

Reported by: zaytsev Owned by: iNode
Priority: critical Milestone: 4.7.0-pre3
Component: mc-vfs Version: master
Keywords: ftp vfs Cc:
Blocked By: Blocking:
Branch state: Votes for changeset: committed-master

Description

Hi!

When you try to login using FTP as a not anonymous user (e.g. user@host) mc segfaults as you enter the address and the username. This became broken very recently, mc build from one week ago worked just fine.

dbg backtraces:

http://www.nopaste.com/p/aG06r983bb
http://www.nopaste.com/p/aeQhfJPfO

Change History

comment:1 Changed 10 years ago by zaytsev

  • Version changed from 4.7.0-pre2 to master
  • Milestone changed from 4.7 to 4.7.0-pre3

comment:2 Changed 10 years ago by iNode

Should we init def_text by NULL instead of ((char*) -1)?

initial_buffer_len = 1 + max ((size_t) width, strlen (def_text));
// strlen((char*) -1); it's isn't correct 

comment:3 Changed 10 years ago by iNode

diff --git a/src/wtools.h b/src/wtools.h
index 1fc45ad..5e71949 100644
--- a/src/wtools.h
+++ b/src/wtools.h
@@ -172,7 +172,7 @@ int quick_dialog_skip (QuickDialog *qd, int nskip);
 /* The input dialogs */
 
 /* Pass this as def_text to request a password */
-#define INPUT_PASSWORD ((char *) -1)
+#define INPUT_PASSWORD ((char *) NULL)
 
 char *input_dialog (const char *header, const char *text,
                    const char *history_name, const char *def_text);

comment:4 Changed 10 years ago by zaytsev

Thanks!!! Attached patch works for me. Will vote for inclusion as soon as a branch is created.

comment:5 Changed 10 years ago by iNode

  • Owner set to iNode
  • Status changed from new to accepted

comment:6 Changed 10 years ago by iNode

  • severity changed from no branch to on rework

It was just workaround. It works but it's invalid because it's allow save input password in history. Please clean manually your history if you use it.

branch:1580_ftp_input_password (parent:master)
changeset: 40057ff3a66b39cdb03c772f43b847ae0b05847d

comment:7 Changed 10 years ago by iNode

  • severity changed from on rework to on review

comment:8 Changed 10 years ago by slavazanko

  • Votes for changeset set to slavazanko

comment:9 Changed 10 years ago by angel_il

  • Votes for changeset changed from slavazanko to slavazanko angel_il
  • severity changed from on review to approved

comment:10 Changed 10 years ago by iNode

  • Status changed from accepted to testing
  • Votes for changeset changed from slavazanko angel_il to commited-master
  • Resolution set to fixed
  • severity changed from approved to merged

comment:11 Changed 10 years ago by iNode

  • Status changed from testing to closed

comment:12 Changed 10 years ago by iNode

  • Status changed from closed to reopened
  • Resolution fixed deleted
  • severity changed from merged to on rework

comment:13 Changed 10 years ago by iNode

  • Status changed from reopened to accepted
  • severity changed from on rework to on review

The same branch, please review:

99d02797923e340b5771cf14150ff8ee0b1c20a1

comment:14 Changed 10 years ago by angel_il

  • Votes for changeset changed from commited-master to angel_il

comment:15 Changed 10 years ago by slavazanko

  • Votes for changeset changed from angel_il to angel_il slavazanko
  • severity changed from on review to approved

comment:16 Changed 10 years ago by iNode

  • Status changed from accepted to testing
  • Votes for changeset changed from angel_il slavazanko to commited-master
  • Resolution set to fixed
  • severity changed from approved to merged

comment:17 Changed 10 years ago by iNode

  • Status changed from testing to closed
Note: See TracTickets for help on using tickets.