Ticket #158 (closed defect: fixed)

Opened 10 years ago

Last modified 9 years ago

[PATCH] changing message codes to names

Reported by: Enrico.Weigelt@…> Owned by: metux
Priority: major Milestone: 4.7
Component: mc-core Version: 4.6.1
Keywords: vote-winnie vote-slavazanko committed-master Cc:
Blocked By: Blocking:
Branch state: Votes for changeset:

Description (last modified by metux) (diff)

this patch changes the message type codes passed to functions like message() from integers to names like D_NORMAL or D_ERROR (mostly taken from rhclub tree)

changeset:154feb51603657694dc7e35a599f390506fdd043
branch:158_message_codes

Committed master:
changeset:5d150562aaeaef5cbe5f68bc55410eaa360cdf4c

Attachments

msg-codes.001.diff (59.0 KB) - added by anonymous 10 years ago.
Added by email2trac

Change History

Changed 10 years ago by anonymous

Added by email2trac

comment:1 Changed 10 years ago by anonymous

  • id set to 158

This message has 1 attachment(s)

comment:2 Changed 10 years ago by metux

  • Keywords review added
  • Description modified (diff)

comment:3 Changed 10 years ago by metux

  • Owner set to metux
  • Status changed from new to accepted

comment:4 Changed 10 years ago by winnie

Patch looks good except one change in src/cmd.c where in line 1226 you delete a char *ptr; can we please move this out of this patch or explain why this is removed there?.

comment:5 Changed 10 years ago by metux

The removed "char* ptr" in cmd.c is unused.

comment:6 Changed 10 years ago by metux

  • Description modified (diff)

comment:7 Changed 10 years ago by winnie

  • Keywords vote-winnie added

Okay.. as the unused pointer is now not longer removed here (but in another ticket) I'll add my vote here.

comment:8 Changed 10 years ago by slavazanko

  • Keywords vote-slavazanko approved added; review removed

this patchset based on patches from mc-ru-fork. I see this good patchset and vote to this.

comment:9 Changed 10 years ago by metux

  • Description modified (diff)

comment:10 Changed 10 years ago by metux

  • Keywords committed-master added; approved removed

comment:11 Changed 10 years ago by winnie

  • Status changed from accepted to testing
  • Resolution set to fixed

comment:12 Changed 10 years ago by winnie

  • Status changed from testing to closed
Note: See TracTickets for help on using tickets.