Mouse wheel on history and menus

[dmartina]

Could we have the mouse wheel operate on menus and history list?

[slavazanko]

if it will made someone more happy - must have :)

[andrew_b]

Created branch 1564_mouse_wheel_menus_listbox. Parent branch: master.
changeset:99a05b076d97ab00067f186956d83fe413698dbb

[dmartina]

Great for the menus! Both horizontal and vertical rotating! :-)

History is pending, isn't it? BTW, the Alt-h History also needs some way to escape. I mean a mouse based way to get the keyboard Esc-Esc behaviour and go back to the panels. Other dialogs have a «Cancel» button but this one doesn't (see, I'm not asking for it). Maybe clicking outside the dialog?

[dmartina]

Hmm, some very fine tuning:

• Wheel on first line rotates main menu
• Wheel on a particular menu rotates this menu
• Wheel outside makes menu loose focus and close. If over panel, panel and selection move.

I wouldn't close menus on wheel movement, just on key clicks. I don't now if this can be distinguished easily.

About the listing panels operated with the mouse wheel, when window is at top or bottom of the list, then selection "jumps" to first/last item. It may be smoother: keep window and decrease/increase selection in single steps.

[andrew_b]

Replying to dmartina:

Maybe clicking outside the dialog?

Already done! :) ​http://www.midnight-commander.org/ticket/312#comment:15

[andrew_b]

Replying to dmartina:

I wouldn't close menus on wheel movement, just on key clicks. I don't now if this can be distinguished easily.

I'll try fix that.

[dmartina]

Replying to andrew_b:

Already done! :) ​http://www.midnight-commander.org/ticket/312#comment:15

I've found it in the ini file! Why does it default to 0?

[dmartina]

Replying to dmartina:

I've found it in the ini file! Why does it default to 0?

Sorry, now I do have read the whole thread about it :) I think that it may be optional for common dialogs (with «Cancel»), but if this one doesn't have other means of mouse-closing...

I don't want to reopen the debate. For my personal use it's fair enough to have the option as is, and now I have permanently set it.

[andrew_b]

Replying to andrew_b:

Replying to dmartina:

I wouldn't close menus on wheel movement, just on key clicks. I don't now if this can be distinguished easily.

I'll try fix that.

changeset:cfe4310a4a758955a4bbf924392ee9b0344754bb

[dmartina]

Much better (background clapping).

Let's do some more checking about boundary conditions.

• When rolling over the right border then selection moves, but not on left, top nor bottom lines (I'm testing with konsole+KDE+Ubuntu). Is that the expected behaviour?
• With Spanish locale, the two last menus (that is "right" and "options") are pushed to the right edge of the window and it doesn't process wheel movements on the two rightmost positions (border line and margin space). In fact, if you click there menu closes! You may reproduce this under default C locale resizing the window to a smaller width.

None of them really matters but you may want to check them.

[dmartina]

Smooth wheel movement on file panels

[dmartina]

Replying to dmartina:

About the listing panels operated with the mouse wheel, when window is at top or bottom of the list, then selection "jumps" to first/last item. It may be smoother: keep window and decrease/increase selection in single steps.

I tried it and I got a patch for screen.c
Move to new ticket or just drop it?

[andrew_b]

Replying to dmartina:

None of them really matters but you may want to check them.

OK, I'll check that.

[andrew_b]

Replying to dmartina:

Replying to dmartina:

About the listing panels operated with the mouse wheel, when window is at top or bottom of the list, then selection "jumps" to first/last item. It may be smoother: keep window and decrease/increase selection in single steps.

I tried it and I got a patch for screen.c

Nice. :) I like the new behavior. Thanks!

Move to new ticket or just drop it?

I think, there is no reason for new ticket. I'll commit your patch to this branch a bit later, after all menu changes.

[andrew_b]

Replying to andrew_b:

Replying to dmartina:

None of them really matters but you may want to check them.

OK, I'll check that.

changeset:c956ba349f6cb630335f44f5302bdf168d81ed3f

[angel_il]

this branch broke mouse wheele behaviour when mc started in putty

[angel_il]

*wheel

[andrew_b]

Most implemented or fixed mouse wheel support items:

• scroll of listboxes
• smooth panel scrolling in first and last pages
• inactive panel is not scrollable now
• horizontal rotation of main menu
• vertical rotation of dropped menu

Also

• if main menu is hidden, single left click on the first screen row calls menu in all panel type: file list, info, tree, quick view
• single mouse click outside menu area closes menu
• if menu is dropped, single middle click executes the selected menu item independently of mouse pointer location

Known problem: if main editor menu is rotated by mouse wheel, it is not refreshed if MC is run under PuTTY.

Please review.

[slavazanko]

Well... behavior in putty it's a another bug. If someone have putty - new tickets with patches are welcome ;)

All work fine. Vote here.

[dmartina]

I use putty and I was trying this. Putty behaviour is as good or as bad as it used to be...

[andrew_b]

Merged to master.

git log --pretty=oneline c66f620..1f0b05b

[andrew_b]

Segfault on GPM_DRAG mouse event above or below drop-down menus.

[andrew_b]

Created 1564_menu_mouse_drag branch. Parent branch master.
changeset:b1721e5b5efcbdc45603a87423f33b5d091e20a6

[slavazanko]

Bug present in anyway :)

[andrew_b]

changeset:eeb9495edce2ce1133807002745011518fe15bfc (forced update)

[iNode]

Looks good.

[andrew_b]

Merged to master.
changeset:95d53b08cfe915fecbe899c1679239668ae7ca08