Ticket #1560 (closed defect: fixed)
Make editor search dialog i18n friendly / auto resizable
| Reported by: | dmartina | Owned by: | andrew_b |
|---|---|---|---|
| Priority: | major | Milestone: | 4.7.0-pre3 |
| Component: | mcedit | Version: | master |
| Keywords: | Cc: | ||
| Blocked By: | Blocking: | ||
| Branch state: | Votes for changeset: | committed-master |
Description
Translated strings may not fit in this fixed size dialog.
Change History
comment:3 Changed 15 years ago by andrew_b
- Blocked By 1487, 1556 added
- Milestone changed from 4.7 to 4.7.0-pre3
comment:7 Changed 15 years ago by andrew_b
- Blocked By 1562 removed
(In #1562) Merged to master.
Initial changeset:f9d6bb075c9cbed89aba9f6e3a201b32e0786399
Final changeset:c057b0a02a69c69ad528ab267bd140d4bef3f358
git log --pretty=oneline 44a094c..bf7b330
comment:8 Changed 15 years ago by andrew_b
- Status changed from new to accepted
- Owner set to andrew_b
comment:11 Changed 15 years ago by andrew_b
- Blocked By 1556 removed
(In #1556) Merged to master.
changeset:434ebd3780d400cffa274b96ea29614e668f58fc
All other dialogs will be fixed in #64.
comment:12 follow-up: ↓ 13 Changed 15 years ago by dmartina
Good for the buttons "friendly" location. Bad for the resizing capabilities. Try a loooooooooooooong translation for "&OK". Nevertheless, milestone may be postponed for this part or try a global solution checking other dialogs. Is that #64?
comment:13 in reply to: ↑ 12 Changed 15 years ago by andrew_b
Replying to dmartina:
Good for the buttons "friendly" location. Bad for the resizing capabilities. Try a loooooooooooooong translation for "&OK".
Yepp, I see.
Nevertheless, milestone may be postponed for this part or try a global solution checking other dialogs. Is that #64?
I think, since this ticket is about editor search dialog, I'll fix that dialog here. Other dialogs will be fixed in #64.
comment:14 Changed 15 years ago by andrew_b
- Version changed from 4.7.0-pre1 to master
- severity changed from no branch to on review
Created 1560_editor_search_dlg_button_locations branch. Parent branch: master.
changeset:8f412b11e2a563fe4742616333b55828174fbbc9
comment:16 Changed 15 years ago by angel_il
- Votes for changeset changed from slavazanko to slavazanko angel_il
- severity changed from on review to approved
comment:17 Changed 15 years ago by andrew_b
- Status changed from accepted to testing
- Votes for changeset changed from slavazanko angel_il to commited-master
- Resolution set to fixed
- severity changed from approved to merged
- Blocking 64 removed
Merged to master.
changeset:a437ed5d528d2304f52993e69d095dbedd17fdcc
The search options dialog is using quick_dialog from wtools.c. Absolute positions are set in editcmd_dialogs.c whilst strings are later translated in quick_dialog() so there is no way to relate them.
It's difficult, but I find some of the options (as "in encodings") hard to translate in 20 chars.
On the fly, I could think of reusing the xpos in QuickWidget?, overcharged so that negative values as -n may represent nth column. In quick_dialog a double pass would be required: