Ticket #1559 (closed enhancement: fixed)

Opened 9 years ago

Last modified 9 years ago

Search results highlighting in mcedit is too subtle

Reported by: rt Owned by:
Priority: major Milestone: 4.7.1
Component: mcedit Version: master
Keywords: Cc:
Blocked By: Blocking:
Branch state: Votes for changeset: committed-master

Description

It's a bit tricky to *search results of a search* in mcedit when default blue background is set. Default colour for search results highlighting should be probably changed to something more sensible; to my mind orange or red would be OK.

It also would be fine to add support for more advanced results fontification like selecting search results in bold face.

Change History

comment:1 Changed 9 years ago by angel_il

  • Milestone set to 4.7.0-pre4

comment:2 Changed 9 years ago by angel_il

#1667 related bug

comment:3 Changed 9 years ago by slavazanko

  • Milestone changed from 4.7.0-pre4 to 4.7

comment:4 Changed 9 years ago by angel_il

for good result change 'editbold' in [editor] like this

editor=yellow;brightgreen

comment:5 Changed 9 years ago by angel_il

  • Status changed from new to closed
  • Resolution set to wontfix

comment:6 Changed 9 years ago by angel_il

  • Status changed from closed to reopened
  • Resolution wontfix deleted

khm...

comment:7 Changed 9 years ago by angel_il

branch: 1559_search_results_highlighting_fix
changeset: d970bccf5480eaed25f20af7c545b659a138ec07

comment:8 Changed 9 years ago by angel_il

  • severity changed from no branch to on review
  • Milestone changed from 4.7 to 4.7.1

comment:9 follow-ups: ↓ 11 ↓ 12 Changed 9 years ago by slavazanko

Don't touch defailt.ini, please. This is ugly skin, but this is default (for respect of old habits ;).

Use 'featured' skin instread, please.

comment:10 Changed 9 years ago by slavazanko

  • severity changed from on review to on rework

comment:11 in reply to: ↑ 9 Changed 9 years ago by rt

Replying to slavazanko:

Don't touch defailt.ini, please. This is ugly skin, but this is default (for respect of old habits ;).

Use 'featured' skin instread, please.

Well, my point is to improve the colour exactly used by default. But if you insist on changing some other scheme you should add a notice somewhere written in bold letters so users could change their colour theme just after installation.
Please correct me if I am wrong and default.ini is not default colour scheme now.

comment:12 in reply to: ↑ 9 Changed 9 years ago by andrew_b

  • Version set to master

Replying to slavazanko:

Don't touch defailt.ini, please.

In this case I disagree with you.

Use 'featured' skin instread, please.

I use default skin and I wont see found text more clean. :)

comment:13 Changed 9 years ago by andrew_b

  • Votes for changeset set to andrew_b

comment:14 Changed 9 years ago by slavazanko

  • Votes for changeset changed from andrew_b to andrew_b slavazanko
  • severity changed from on rework to approved

Okay, this little fix should not be cause for holy wars.
Vote here.

comment:15 Changed 9 years ago by angel_il

  • Status changed from reopened to closed
  • Votes for changeset changed from andrew_b slavazanko to committed-master
  • Resolution set to fixed
  • severity changed from approved to merged
Note: See TracTickets for help on using tickets.