Ticket #1552 (closed defect: fixed)

Opened 10 years ago

Last modified 10 years ago

Redesign listing mode dialog

Reported by: dmartina Owned by: andrew_b
Priority: minor Milestone: 4.7.0-pre3
Component: mc-core Version: 4.7.0-pre1
Keywords: Cc:
Blocked By: Blocking:
Branch state: Votes for changeset: committed-master

Description (last modified by andrew_b) (diff)

"Listing mode" surely is the most used dialog in MC. The 'OK' and 'Cancel' buttons are in a non-usual top-left placement. A common dialog engine would be nicer, but it's very hard work and it's not realistic to expect it in short.
I'm attaching a fix-up.

Attachments

boxes.c.diff (3.6 KB) - added by dmartina 10 years ago.
boxes2.c.diff (3.4 KB) - added by dmartina 10 years ago.
Patch refurbished to fit daily git.

Change History

Changed 10 years ago by dmartina

comment:1 Changed 10 years ago by andrew_b

  • Status changed from new to accepted
  • Owner set to andrew_b

Changed 10 years ago by dmartina

Patch refurbished to fit daily git.

comment:2 Changed 10 years ago by andrew_b

  • severity changed from no branch to on review
  • Type changed from enhancement to defect
  • Description modified (diff)
  • Milestone changed from 4.7 to 4.7.0-pre3

David, thanks for your work, but I used another way.
Also I fixed button locations in 'Sort order' dialog.
Created branch 1552_nonstd_button_location. Parent branch: master.
Inital changeset:0dc288c63fc8821ab7dd5a2d0aa00ba5a41b1d18
Final changeset:daaeff71925f72fd569b29a09011d265e859f989

git log --pretty=oneline 0dc288c^..daaeff7

comment:3 Changed 10 years ago by dmartina

Never mind, I was just ordering all the stuff in the patches folder. Thanks.

Later I'll try to stress test your patch with loooooooong translations :-)

comment:4 Changed 10 years ago by angel_il

  • Votes for changeset set to angel_il

comment:5 follow-up: ↓ 6 Changed 10 years ago by iNode

            /* 0 */ QUICK_BUTTON (0, dlg_width, dlg_height - 3, dlg_height, N_("&Cancel"), B_CANCEL, NULL), 

is too long. Please try limit line length by 100 characters (btw 80 the best, but the best that is the enemy of good).

comment:6 in reply to: ↑ 5 Changed 10 years ago by slavazanko

Replying to iNode:

            /* 0 */ QUICK_BUTTON (0, dlg_width, dlg_height - 3, dlg_height, N_("&Cancel"), B_CANCEL, NULL), 

is too long. Please try limit line length by 100 characters (btw 80 the best, but the best that is the enemy of good).

changeset:160ffd6f702676ea2eb18346b26eb9a73a4c5c44

Is looks good?

comment:7 Changed 10 years ago by iNode

  • Votes for changeset changed from angel_il to angel_il iNode
  • severity changed from on review to approved

Much better. Thanks.

comment:8 Changed 10 years ago by andrew_b

  • Status changed from accepted to testing
  • Votes for changeset changed from angel_il iNode to commited-master
  • Resolution set to fixed
  • severity changed from approved to merged

Merged to master.

git log --pretty=oneline edddd5f..f3916f0

comment:9 Changed 10 years ago by andrew_b

  • Status changed from testing to closed
Note: See TracTickets for help on using tickets.