Ticket #1550 (closed defect: fixed)
code cleanup befor 4.7.0-pre2
| Reported by: | winnie | Owned by: | andrew_b |
|---|---|---|---|
| Priority: | blocker | Milestone: | 4.7.0-pre2 |
| Component: | mc-core | Version: | 4.7.0-pre1 |
| Keywords: | Cc: | ||
| Blocked By: | Blocking: | ||
| Branch state: | Votes for changeset: | committed-master |
Description
The sourcecode should be cleaned up before the release.. we should avoid every warning.
../../edit/editdraw.c: In function ‘print_to_widget’: ../../edit/editdraw.c:279: warning: unused variable ‘str’ ../../../src/tty/key.c: In function ‘get_modifier’: ../../../src/tty/key.c:721: warning: comparison between pointer and integer ../../../src/tty/win.c:156: warning: implicit declaration of function ‘getenv’ ../../../src/tty/win.c:156: warning: initialization makes pointer from integer without a cast ../../../src/tty/tty-slang.c: In function ‘tty_print_anychar’: ../../../src/tty/tty-slang.c:487: warning: pointer targets in passing argument 1 of ‘str_term_form’ differ in signedness ../../src/dialog.c: In function ‘add_widget’: ../../src/dialog.c:334: warning: control reaches end of non-void function ../../src/layout.c: In function ‘save_panel_dir’: ../../src/layout.c:1131: warning: implicit declaration of function ‘vfs_translate_url’ ../../src/layout.c:1131: warning: assignment makes pointer from integer without a cast ../../src/widget.c: In function ‘listbox_event’: ../../src/widget.c:2330: warning: implicit declaration of function ‘mc_refresh’
Change History
comment:2 Changed 15 years ago by winnie
- severity changed from no branch to on rework
See branch 1550_code_cleanup for a start.
comment:3 Changed 15 years ago by andrew_b
- Status changed from new to accepted
- Owner set to andrew_b
comment:4 Changed 15 years ago by slyfox
Pushed more fixes.
new tip changeset:f74a6813ead7390754431a4e6c692964dc96d9f5
comment:5 Changed 15 years ago by angel_il
changeset: f2b6f635cc67231c35cb2cf49e5058bc297efe56
comment:7 Changed 15 years ago by andrew_b
- Votes for changeset changed from angel_il to angel_il andrew_b
- severity changed from on rework to approved
comment:8 Changed 15 years ago by andrew_b
- Status changed from accepted to testing
- Votes for changeset changed from angel_il andrew_b to commited-master
- Resolution set to fixed
- severity changed from approved to merged
Merged to master.
Start changeset:510265b41cd4b71b90dad421b44174fdab07941d
Finish changeset:7e13f0a5c181ce81d04dcf98206977e96279defe
git log --pretty=oneline 6ff684c..7e13f0a
comment:10 Changed 15 years ago by angel_il
- Status changed from closed to reopened
- Resolution fixed deleted
comment:11 Changed 15 years ago by iNode
Build error:
In file included from datasource.c:61:
internal.h:86: error: expected specifier-qualifier-list before ‘FILE’
In file included from internal.h:316,
from datasource.c:61:
...
and so on
comment:12 Changed 15 years ago by slavazanko
- Priority changed from major to blocker
- Votes for changeset commited-master deleted
- severity changed from merged to on review
created branch 1550_add_forgotten_include
initial changeset:8407f5fd9a24e3ce3a93d5a15fc4c59015335a51
review.
comment:14 Changed 15 years ago by angel_il
changeset: 89306849c7c691fa04fc8eeb92a08972fb9fd80
comment:15 Changed 15 years ago by slavazanko
- Votes for changeset changed from iNode to iNode slavazanko
- severity changed from on review to approved
comment:16 Changed 15 years ago by angel_il
changeset: d89306849c7c691fa04fc8eeb92a08972fb9fd80
comment:17 Changed 15 years ago by slavazanko
- Status changed from reopened to closed
- Votes for changeset changed from iNode slavazanko to commited-master
- Resolution set to fixed
- severity changed from approved to merged
Note: See
TracTickets for help on using
tickets.
Maybe we should compile with -Werror per default, this would be a good qa for mc.