Ticket #1546 (closed defect: fixed)

Opened 9 years ago

Last modified 9 years ago

build broken for --with-screen=ncurses

Reported by: jue Owned by: angel_il
Priority: major Milestone: 4.7.0-pre2
Component: mc-tty Version: master
Keywords: Cc:
Blocked By: Blocking:
Branch state: Votes for changeset: committed-master

Description (last modified by angel_il) (diff)

mc, version 4.7.0-pre1-174-g39c875a, configured to use ncurses:

tty-ncurses.c: In function 'tty_print_anychar':
tty-ncurses.c:301: error: 's' undeclared (first use in this function)

Trivial fix:

diff --git a/src/tty/tty-ncurses.c b/src/tty/tty-ncurses.c
index a698b9a..d511037 100644
--- a/src/tty/tty-ncurses.c
+++ b/src/tty/tty-ncurses.c
@@ -298,7 +298,7 @@ tty_print_anychar (int c)
         } else {
             str[res] = '\0';
         }
-        addstr (str_term_form (s));
+        addstr (str_term_form (str));
     } else {
         addch (c);
     }

Change History

comment:1 Changed 9 years ago by andrew_b

  • Milestone changed from 4.7 to 4.7.0-pre2

comment:2 Changed 9 years ago by angel_il

  • Description modified (diff)

comment:3 Changed 9 years ago by angel_il

  • Status changed from new to accepted
  • Owner set to angel_il

comment:4 Changed 9 years ago by angel_il

  • Votes for changeset set to angel_il
  • severity changed from no branch to on review

branch: 1546_fix (parent: master)
changeset: ee96f770e0685367c47e47183f510ab52e4292ed

comment:5 Changed 9 years ago by andrew_b

  • Votes for changeset changed from angel_il to angel_il andrew_b
  • severity changed from on review to approved

comment:6 Changed 9 years ago by angel_il

  • Status changed from accepted to testing
  • Votes for changeset changed from angel_il andrew_b to commited-master
  • Resolution set to fixed
  • severity changed from approved to merged

comment:7 Changed 9 years ago by angel_il

  • Status changed from testing to closed
Note: See TracTickets for help on using tickets.