Ticket #1519 (closed enhancement: fixed)

Opened 10 years ago

Last modified 10 years ago

Editor Search/Replace in selection only

Reported by: dborca Owned by: angel_il
Priority: major Milestone: 4.7.0-pre2
Component: mcedit Version: 4.7.0-pre1
Keywords: Cc:
Blocked By: Blocking:
Branch state: Votes for changeset: committed-master

Description

Patch attached (no dialog option, though, because that may change with "Whole words"/"set bookmarks", anyway).

Attachments

mc-4.7.0-pre1.search_in_selection.patch (2.4 KB) - added by dborca 10 years ago.

Change History

Changed 10 years ago by dborca

comment:1 Changed 10 years ago by angel_il

  • Status changed from new to accepted
  • Owner set to angel_il

comment:2 Changed 10 years ago by angel_il

branch: 1519_search_replace_in_selection
changeset: 7178d4be3143554fd1f31a47173962f37cf2cf25

comment:3 Changed 10 years ago by slavazanko

  • severity changed from no branch to on review

comment:4 Changed 10 years ago by angel_il

comment:5 Changed 10 years ago by slavazanko

Is last commit in branch is a rebased three patches (original and my patches)?

comment:6 Changed 10 years ago by andrew_b

  • Votes for changeset set to andrew_b

Cool! My vote here.

comment:7 Changed 10 years ago by iNode

  • Votes for changeset changed from andrew_b to andrew_b iNode
  • severity changed from on review to approved

Looks good.

I think things like

long start_mark = 0;
long end_mark = edit->last_byte; 

should be unsigned, cause signed variant has no content, but it can be fixed lately.

comment:8 Changed 10 years ago by angel_il

  • Status changed from accepted to testing
  • Votes for changeset changed from andrew_b iNode to commited-master
  • Resolution set to fixed
  • severity changed from approved to merged

comment:9 Changed 10 years ago by angel_il

  • Status changed from testing to closed
Note: See TracTickets for help on using tickets.