Ticket #1519 (closed enhancement: fixed)
Editor Search/Replace in selection only
| Reported by: | dborca | Owned by: | angel_il |
|---|---|---|---|
| Priority: | major | Milestone: | 4.7.0-pre2 |
| Component: | mcedit | Version: | 4.7.0-pre1 |
| Keywords: | Cc: | ||
| Blocked By: | Blocking: | ||
| Branch state: | Votes for changeset: | committed-master |
Description
Patch attached (no dialog option, though, because that may change with "Whole words"/"set bookmarks", anyway).
Attachments
Change History
comment:1 Changed 15 years ago by angel_il
- Owner set to angel_il
- Status changed from new to accepted
comment:2 Changed 15 years ago by angel_il
branch: 1519_search_replace_in_selection
changeset: 7178d4be3143554fd1f31a47173962f37cf2cf25
comment:3 Changed 15 years ago by slavazanko
- severity changed from no branch to on review
Some fixies:
- Fix search start position if cursor placed beyond marked text
- Fixed handle of 'In selection' option in 'search' dialog
Branch now looks good.
review, please.
comment:4 Changed 15 years ago by angel_il
Changeset: d893ccc81f1e7ced9c1cd80361cc94970605b12a
comment:5 Changed 15 years ago by slavazanko
Is last commit in branch is a rebased three patches (original and my patches)?
comment:7 Changed 15 years ago by iNode
- Votes for changeset changed from andrew_b to andrew_b iNode
- severity changed from on review to approved
Looks good.
I think things like
long start_mark = 0; long end_mark = edit->last_byte;
should be unsigned, cause signed variant has no content, but it can be fixed lately.
Note: See
TracTickets for help on using
tickets.
