Ticket #1517 (assigned defect)

Opened 9 years ago

Last modified 3 years ago

User can expand tree node, but there are no visible keys for collapsing it back

Reported by: sergey-feo Owned by:
Priority: minor Milestone: Future Releases
Component: mc-core Version: master
Keywords: Cc: janek_listy@…
Blocked By: Blocking:
Branch state: no branch Votes for changeset:

Description

(Excuse me for my bad English)

When we use "directory tree" mode in panel, we can expand (open) nodes by pressing enter. But enter can't collapse (close) node back. And there are no any keys for it in status line at bottom.

Attachments

9541-added-info-whether-enter-was-pressed-on-an-entry.patch (1.5 KB) - added by Janek Kozicki 9 years ago.
first commit: pass down information whether Enter was pressed
9542-ticket-1517-DONE-Enter-mouse_click-will-fold-unfold-.patch (5.8 KB) - added by Janek Kozicki 9 years ago.
second commit: fold or unfold

Change History

comment:1 Changed 9 years ago by andrew_b

  • Status changed from new to closed
  • Resolution set to invalid

Please read the MC documentation before create tickets.
Press the F1 key on tree and RTFM.

comment:2 Changed 9 years ago by slavazanko

  • Version 4.7.0-pre1 deleted
  • Milestone future releases deleted

comment:3 Changed 9 years ago by sergey-feo

Press the F1 key on tree and RTFM.

I pressed F1 key on tree and carefully read TFM. I did not find any key binding for collapse expanded node. F3 is not this key: it deletes node from tree but not collapse it.

It is possible that you are did not understand me because of my bad English. Let see on example.

Let initial tree view is:

/bin
/lib

After pressing key "Enter" on etc:

/bin
/lib
│ ├─ firmware
│ ├─ modules
│ └─ udev

What key should I press on lib to make tree view as follows? :
/bin
/lib

In other words, pressing "enter" on tree node in mc is equialent to pressing "right" on tree node in Konqueror. But what key binding in mc is equialent to pressing "left" on tree node in Konqueror?

comment:4 Changed 9 years ago by Janek Kozicki

this is fixed in my trac ticked #2202, pressing Enter on unfolded dir will collapse it.

comment:5 Changed 9 years ago by Janek Kozicki

  • Status changed from closed to reopened
  • Cc janek_listy@… added
  • Resolution invalid deleted

comment:6 Changed 9 years ago by Janek Kozicki

  • Owner set to Janek Kozicki
  • Status changed from reopened to assigned

comment:7 Changed 9 years ago by Janek Kozicki

  • Milestone set to Future Releases

Changed 9 years ago by Janek Kozicki

first commit: pass down information whether Enter was pressed

Changed 9 years ago by Janek Kozicki

second commit: fold or unfold

comment:8 Changed 9 years ago by Janek Kozicki

  • Status changed from assigned to testing
  • Resolution set to fixed

I still don't know how to let you fetch my patches, so I'm attaching here the output of "git format-patch". I consider it self-contained and complete - ready for merge.

comment:9 Changed 9 years ago by Janek Kozicki

  • Version set to master

comment:10 Changed 9 years ago by andrew_b

  • Status changed from testing to reopened
  • Resolution fixed deleted

resolution set to fixed

No fixed. Pleas read the http://www.midnight-commander.org/wiki/WorkingGuideLines.

comment:11 Changed 9 years ago by Janek Kozicki

I'm sorry, thank you.

comment:12 Changed 3 years ago by andrew_b

  • Status changed from reopened to assigned
  • Owner Janek Kozicki deleted
  • Branch state set to no branch
Note: See TracTickets for help on using tickets.