Ticket #1498 (closed defect: wontfix)

Opened 12 years ago

Last modified 20 months ago

Narrow panels if terminal window is too wide

Reported by: ache Owned by:
Priority: major Milestone:
Component: mc-tty Version: master
Keywords: Cc:
Blocked By: Blocking:
Branch state: no branch Votes for changeset:

Description

If a terminal window is wider than 512 symbols, MC starts with panels only 80 symbols wide (40 each). If the window is resized, panels are resized correctly, however.

Change History

comment:1 Changed 12 years ago by angel_il

i try run terminal 630х200 - no problem.

comment:2 Changed 12 years ago by ache

Gentoo, AMD64, gnone-terminal 2.24.2-r1 or XFCE terminal 0.2.12. Problem still observed at 630х200 as well.

630х200 or 200x630?

Occurs at MC start ONLY. When window is resized to width >512, MC behaves correctly.

comment:3 Changed 12 years ago by angel_il

i set font 2pt and start terminal ~630х200
width: 630
height: 200

comment:4 Changed 12 years ago by andrew_b

  • Component changed from mc-core to mc-tty
  • Blocked By 1474 added

Confirmed with slang-2.1.3. This bug is S-Lang related, not NCurses.

Currently, during initalization S-Lang limits the scren size. Look at SLtt_get_screen_size():

   if ((r <= 0) || (r > SLTT_MAX_SCREEN_ROWS)) r = 24;
   if ((c <= 0) || (c > SLTT_MAX_SCREEN_COLS)) c = 80;
   SLtt_Screen_Rows = r;
   SLtt_Screen_Cols = c;

where r and c are the actual screen sizes. But

# define SLTT_MAX_SCREEN_COLS 512 
# define SLTT_MAX_SCREEN_ROWS 512 

comment:5 Changed 12 years ago by iNode

# define SLTT_MAX_SCREEN_COLS 512 
# define SLTT_MAX_SCREEN_ROWS 512

So, it's resonable library "feature".
If you think this is bug, please write
bug report to s-lang developers.

comment:6 Changed 12 years ago by iNode

  • Status changed from new to closed
  • Resolution set to wontfix

comment:7 Changed 12 years ago by andrew_b

  • Blocked By 1474 removed

(In #1474) Merged to master.

git log --pretty=oneline 3eeeb35..e1cbec7

comment:8 Changed 5 years ago by andrew_b

  • Branch state set to no branch
  • Milestone Future Releases deleted

comment:9 follow-up: ↓ 10 Changed 20 months ago by xMstSpider

  • Priority changed from trivial to major
  • Status changed from closed to reopened
  • Resolution wontfix deleted

Hi,
I am using a ultra-wide screen with 5120x1440 resolution and I am hit with this bug as well.

$  tput cols
632
$  tput lines
80

Is there possible to increase the SLTT_MAX_SCREEN_* variables in slang or completely remove the check?

Alternatively, to allow manual configuration of COLS and LINES in MC settings.

Thank you

comment:10 in reply to: ↑ 9 ; follow-up: ↓ 11 Changed 20 months ago by andrew_b

  • Status changed from reopened to closed
  • Resolution set to wontfix

Replying to xMstSpider:

Is there possible to increase the SLTT_MAX_SCREEN_* variables in slang or completely remove the check?

SLTT_MAX_SCREEN_* are internal S-Lang constants. MC unable to change them at all. If you want you can patch S-Lang in your system.
A year ago these constants were removed. See #3980 for details.

Alternatively, to allow manual configuration of COLS and LINES in MC settings.

COLS and LINES are variables set by parent shell. Child process cannot change variables of parent one.

comment:11 in reply to: ↑ 10 ; follow-up: ↓ 12 Changed 20 months ago by xMstSpider

Replying to andrew_b:

A year ago these constants were removed. See #3980 for details.

Nice, thanks

COLS and LINES are variables set by parent shell. Child process cannot change variables of parent one.

I know I just talked about manually settings the size of MC window. But I read through #3980 and I understand the slang must by updated instead of MC.
BTW reg to the comments in #3980 - would it be possible to use ncurses instead of slang or is it too much work to do?

Thanks

comment:12 in reply to: ↑ 11 ; follow-up: ↓ 13 Changed 20 months ago by andrew_b

Replying to xMstSpider:

would it be possible to use ncurses instead of slang or is it too much work to do?

./configure --with-screen=ncursesw

comment:13 in reply to: ↑ 12 Changed 20 months ago by xMstSpider

Replying to andrew_b:

Replying to xMstSpider:

would it be possible to use ncurses instead of slang or is it too much work to do?

./configure --with-screen=ncursesw

Thanks

Note: See TracTickets for help on using tickets.